web: redirect /l/download to App Store #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests failing due to #679 |
apps/daimo-web/src/middleware.ts
Outdated
| const urlAppStore = "https://apps.apple.com/us/app/daimo/id6459700343"; | ||
| const urlPlay = "https://play.google.com/store/apps/details?id=com.daimo"; | ||
| if (ua.includes("Android")) return urlPlay; | ||
| else if (ua.includes("iPhone")) return urlAppStore; |
There was a problem hiding this comment.
looks like we have some utils for this same heuristic in https://github.com/daimo-eth/daimo/blob/master/apps/daimo-web/src/utils/platform.ts, want to dedupe?
nalinbhardwaj
approved these changes
Feb 8, 2024
apps/daimo-web/src/middleware.ts
Outdated
| const urlAppStore = "https://apps.apple.com/us/app/daimo/id6459700343"; | ||
| const urlPlay = "https://play.google.com/store/apps/details?id=com.daimo"; | ||
| const platform = detectPlatform(ua); | ||
| if (platform === "ios") return urlAppStore; |
There was a problem hiding this comment.
just import and return downloadMetadata[platform].url should work no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #666