-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix expo doctor #638
fix expo doctor #638
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice cleanup
You could add it to the root project lint, too
Current
"lint": "turbo lint && syncpack list-mismatches",
After
"lint": "turbo lint && syncpack list-mismatches && expo-doctor",
holding off on merging this, it's weird but it seems like (at least on my laptop) |
cb84aa7
to
4a50f99
Compare
bea7c91
to
bdfd9a2
Compare
may be able to supersede with #635 |
superseded by #635 |
expo doctor
has been failing on EAS for a while: https://expo.dev/accounts/daimo/projects/daimo/builds/c92a6039-c8eb-44b5-8c5c-769cbc8fe85dAndroid builds hadn't been working on my new laptop and some googling suggested running that, and it did indeed fix local builds not working, so this is probably a good change to make.