Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix expo doctor #638

Closed
wants to merge 2 commits into from
Closed

fix expo doctor #638

wants to merge 2 commits into from

Conversation

nalinbhardwaj
Copy link
Member

expo doctor has been failing on EAS for a while: https://expo.dev/accounts/daimo/projects/daimo/builds/c92a6039-c8eb-44b5-8c5c-769cbc8fe85d

Android builds hadn't been working on my new laptop and some googling suggested running that, and it did indeed fix local builds not working, so this is probably a good change to make.

Copy link

socket-security bot commented Jan 21, 2024

Copy link
Member

@dcposch dcposch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice cleanup

You could add it to the root project lint, too

Current

    "lint": "turbo lint && syncpack list-mismatches",

After

    "lint": "turbo lint && syncpack list-mismatches && expo-doctor",

@nalinbhardwaj
Copy link
Member Author

holding off on merging this, it's weird but it seems like (at least on my laptop) npm run dev has significantly longer startup time after this commit? kinda wack

@nalinbhardwaj nalinbhardwaj force-pushed the nibnalin/android-nfc-intent branch from cb84aa7 to 4a50f99 Compare January 21, 2024 07:57
@dcposch dcposch changed the base branch from nibnalin/android-nfc-intent to master January 21, 2024 09:01
@dcposch dcposch force-pushed the nibnalin/expo-doctor branch from bea7c91 to bdfd9a2 Compare January 22, 2024 07:10
@dcposch
Copy link
Member

dcposch commented Jan 22, 2024

This doesn't entirely fix expo-doctor

image

image

@dcposch dcposch added this to the 2024-01-22 milestone Jan 22, 2024
@dcposch dcposch modified the milestones: 2024-01-22, 2024-01-29 Jan 29, 2024
@dcposch
Copy link
Member

dcposch commented Feb 5, 2024

may be able to supersede with #635

@dcposch dcposch removed this from the 2024-01-29 milestone Feb 5, 2024
@dcposch
Copy link
Member

dcposch commented Feb 13, 2024

superseded by #635

@dcposch dcposch closed this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants