Show Landline transfers in history #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
andrewliu08
force-pushed
the
andrew/landline-deposit
branch
from
0095ad3 to
ff9f71d
Compare
andrewliu08
force-pushed
the
andrew/landline-deposit
branch
2 times, most recently
from
e548838 to
c21d9cd
Compare
andrewliu08
force-pushed
the
andrew/landline-deposit
branch
from
2faea79 to
c15f994
Compare
andrewliu08
force-pushed
the
andrew/landline-deposit
branch
from
3c95ded to
e59476c
Compare
dcposch
reviewed
Sep 4, 2024
| } | ||
|
|
||
| export interface LandlineTransfer { | ||
| daimoAddress: Address; |
There was a problem hiding this comment.
maybe worth having LandlineTransfer contain a landlineAccount vs copying in all the fields? either way works for me
There was a problem hiding this comment.
i'm going to reduce the number of fields. in particular, i'll remove bankLogo since it's sending the bytes of a png for each transfer
dcposch
reviewed
Sep 4, 2024
dcposch
reviewed
Sep 4, 2024
dcposch
reviewed
Sep 4, 2024
dcposch
reviewed
Sep 4, 2024
dcposch
reviewed
Sep 4, 2024
dcposch
reviewed
Sep 4, 2024
| "This transaction transferred funds from your connected bank account to your Daimo account.", | ||
| secondPara: () => | ||
| "Bank transfers normally cost a few dollars. Daimo sponsored this transfer, making it free.", | ||
| }, |
dcposch
approved these changes
Sep 4, 2024
|
here are some more details about the lifecycle of landline-related clogs in the mobile app. Added this as a comment in the matching code as well Landline deposit lifecycle:
Landline withdrawal lifecycle:
|
andrewliu08
force-pushed
the
andrew/landline-deposit
branch
from
3178ed8 to
700ca88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots
For mobile apps that are up to date
Transfers in "processing" state
Transfers in "failed" and "completed" state
Help modals
For mobile apps that are not up to date