feat: 인기검색어 조회 Client용 API 신규 생성 #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…github.com/daedongbread/bread-map-backend-2 into 345-feature-opensearch-도입-및-데이터-처리-프로그램-구현
JayPark7821
approved these changes
Dec 8, 2023
src/docs/asciidoc/search.adoc
Outdated
| @@ -22,6 +22,9 @@ operation::v1/search/search[snippets='http-request,request-headers,request-param | |||
| === 자동완성 검색어 추천 API [GET] | |||
| operation::v2/search/suggestions[snippets='http-request,request-parameters,http-response,response-fields'] | |||
|
|
|||
| === 인기검색어 검색 테스트 API [GET] | |||
There was a problem hiding this comment.
문서 내용 수정했습니당 (테스트 문자 제외)
| @@ -32,7 +32,7 @@ public class HotKeyword extends BaseEntity { | |||
| private String keyword; | |||
| private int ranking; | |||
|
|
|||
| private HotKeyword(final String keyword, final int ranking) { | |||
| public HotKeyword(final String keyword, final int ranking) { | |||
There was a problem hiding this comment.
해당 생성자를 호출하는 변경사항은 안보이는것같은데 public으로 변경하신 이유가 있을까용?!!
이왕이면 밑에 만들어놓은 스테틱 팩토리 메소드 사용해주시면 감사하겠습니닷!!!!
There was a problem hiding this comment.
static method 활용하는걸로 변경했습니당
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.