-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from manual settings and mappings to index templates #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadoonet
added
new
For new features or options
breaking
For breaking changes
remove
When removing an existing feature
Release Highlight
component:elasticsearch
labels
Oct 24, 2023
dadoonet
force-pushed
the
index-templates
branch
3 times, most recently
from
October 24, 2023 15:02
572b4e7
to
c62d1f1
Compare
It now helps to support aliases and component templates.
dadoonet
force-pushed
the
index-templates
branch
from
October 24, 2023 16:59
31db4dd
to
4305fa7
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This was
linked to
issues
Nov 24, 2023
This was referenced Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
For breaking changes
component:elasticsearch
new
For new features or options
Release Highlight
remove
When removing an existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating "manually" (by code) an index with settings and mappings, it's much better to use Elasticsearch Index Templates and Component Templates.
This PR removes the usage of "on disk" definition files for mappings/settings for 7.x and 8.x clusters.
A benefit of this is that we are not trying anymore to create an index when starting FSCrawler.
This might allow writing to an index alias instead of a concrete index.
Note that for Workplace Search we are still using a on disk file definition.
Closing #1744
Closing #1125
Closing #643