Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from manual settings and mappings to index templates #1746

Merged
merged 12 commits into from
Nov 24, 2023

Conversation

dadoonet
Copy link
Owner

Instead of creating "manually" (by code) an index with settings and mappings, it's much better to use Elasticsearch Index Templates and Component Templates.

This PR removes the usage of "on disk" definition files for mappings/settings for 7.x and 8.x clusters.
A benefit of this is that we are not trying anymore to create an index when starting FSCrawler.

This might allow writing to an index alias instead of a concrete index.

Note that for Workplace Search we are still using a on disk file definition.

Closing #1744
Closing #1125
Closing #643

@dadoonet dadoonet added new For new features or options breaking For breaking changes remove When removing an existing feature Release Highlight component:elasticsearch labels Oct 24, 2023
@dadoonet dadoonet added this to the 2.10 milestone Oct 24, 2023
@dadoonet dadoonet self-assigned this Oct 24, 2023
@dadoonet dadoonet marked this pull request as draft October 24, 2023 14:36
@dadoonet dadoonet force-pushed the index-templates branch 3 times, most recently from 572b4e7 to c62d1f1 Compare October 24, 2023 15:02
@dadoonet dadoonet marked this pull request as ready for review October 24, 2023 21:35
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dadoonet dadoonet merged commit 4e64e48 into master Nov 24, 2023
13 checks passed
@dadoonet dadoonet deleted the index-templates branch November 24, 2023 12:33
This was linked to issues Nov 24, 2023
@dadoonet dadoonet linked an issue Nov 24, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking For breaking changes component:elasticsearch new For new features or options Release Highlight remove When removing an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for Elasticsearch 6 Index alias not accepted Add support for index templates
1 participant