Build with Poetry (#1) #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix deprecated read_schema in new pyarrow versions https://github.com/dacort/athena-federation-python-sdk/pull/13/files * Create .flake8 * Use poetry Update versions * rename project folder * Python CI * lint * remove subfolders * bump CI versions * simplify package name * remove flake8 AttributeError: 'EntryPoints' object has no attribute 'get' > Because importlib-metadata releases v5.0.0 yesterday which it remove deprecated endpoint https://stackoverflow.com/questions/73929564/entrypoints-object-has-no-attribute-get-digital-ocean * megalinter fixes * cleanup lock * drop AWS Role from CI * make test * test coverage * lint Makefile * .PHONY all * Update Makefile * disable MAKEFILE_CHECKMAKE
|
Hope this isn't too much divergence. |
Bumps [black](https://github.com/psf/black) from 20.8b1 to 24.3.0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](https://github.com/psf/black/commits/24.3.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* pytest-watcher * ignore coverage files * test handler * pass test_handler
* TABLE_DEF * test_ReadRecordsRequest * expect coverage
|
Rock on! There's a lot here, but let me try to take a look in the next day or two! |
* update README * arm64v8/python:3.12.5 * docker-poetry-config * switch ports * run minimal dockerfile * smarter * remove cache * --no-root * move example into module * expose lambda_handler on port 9000 * pull out example * IMG = local/athena-federation * image build --platform=linux/amd64 * container run $(PLAT) * ARCH = amd64 * example.handler.sample_handler * install from wheel * make docker works! docker-stop docker-build docker-detached lambda-ping lambda-list-schemas * cleanup Dockerfile * cov-report * WORKDIR * main coverage
dacort
reviewed
Aug 19, 2024
pyproject.toml
Outdated
| name = "athena-federation" | ||
| version = "0.1.2" | ||
| description = "Unofficial Python SDK for Athena Federation" | ||
| authors = ["Damon P. Cortesi <[email protected]>", "Ernest Prabhakar <[email protected]>"] |
There was a problem hiding this comment.
Suggested change
| authors = ["Damon P. Cortesi <DamonPCortesi@gmail.com>", "Ernest Prabhakar <[email protected]>"] | |
| authors = ["Damon P. Cortesi <d.lifehacker@gmail.com>", "Ernest Prabhakar <[email protected]>"] |
dacort
reviewed
Aug 19, 2024
pyproject.toml
Outdated
Comment on lines
8
to
10
| homepage = "https://github.com/quiltdata/athena-federation-python-sdk" | ||
| repository = "https://github.com/quiltdata/athena-federation-python-sdk" | ||
| documentation = "https://github.com/quiltdata/athena-federation-python-sdk" |
There was a problem hiding this comment.
Should we change these back to dacort repo?
There was a problem hiding this comment.
Suggested change
| homepage = "https://github.com/quiltdata/athena-federation-python-sdk" | |
| repository = "https://github.com/quiltdata/athena-federation-python-sdk" | |
| documentation = "https://github.com/quiltdata/athena-federation-python-sdk" | |
| homepage = "https://github.com/dacort/athena-federation-python-sdk" | |
| repository = "https://github.com/dacort/athena-federation-python-sdk" | |
| documentation = "https://github.com/dacort/athena-federation-python-sdk" |
dacort
reviewed
Aug 19, 2024
Dockerfile
Outdated
|
|
||
| COPY example/ ./ | ||
| RUN ls ./ | ||
| COPY example/ ./example |
There was a problem hiding this comment.
For some reason when I ran the make lambda-ping below, I got back this error:
Unable to import module 'example.handler': No module named 'example'
Looking into why, but feel free to comment/fix if you know.
There was a problem hiding this comment.
Probably a missing dependency in the Makefile for that action. I'll take a look.
There was a problem hiding this comment.
Doh! Now I'm seeing this error everywhere. I have this horrible feeling I never got it to work, but simply mis-read the error message...
There was a problem hiding this comment.
Whew. LAMBDA_TASK_ROOT fixes it. Rolling into 0.1.3
dacort
requested changes
Aug 19, 2024
dacort
reviewed
Aug 19, 2024
Dockerfile
Outdated
|
|
||
| COPY example/ ./ | ||
| RUN ls ./ | ||
| COPY example/ ./example |
There was a problem hiding this comment.
Suggested change
| COPY example/ ./example | |
| COPY example/ ${LAMBDA_TASK_ROOT}/example |
Per https://docs.aws.amazon.com/lambda/latest/dg/python-image.html LAMBDA_TASK_ROOT is the default path for modules.
* fix ownership * use toml for version * LAMBDA_TASK_ROOT * bump version * revert use of toml * hacked Dockerfile that works * minimal Dockerfil * even more minimal
* support types * lint types * fix type errors * retrofit CHANGELOG * extract transpose_data * ignore from_arrays type error * fix coverage * cleanup * final lint
* Move py.typed into package folder * bump version * reenable PYTHON_MYPY * lint all files To match MYPY
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix deprecated read_schema in new pyarrow versions
Use poetry
rename project folder
Python CI
lint
make test