-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support the bestEffort flag #84
Conversation
@slackhappy thank you! |
oops sorry - one more update to the typescript defs and the docs |
@@ -91,6 +91,11 @@ Pass top level domain as a hint | |||
|
|||
Pass an HTTP "Content-Encoding" value as a hint | |||
|
|||
#### bestEffort | |||
|
|||
Set to true to give best-effort answer, instead of UNKNOWN_LANGUAGE. May be useful for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description is from
node-cld/deps/cld/public/compact_lang_det.h
Line 373 in 1a13570
kCLDFlagBestEffort |
@dachev, ready for re-review, I added documentation and updated the ts defs. Thanks so much for considering this PR! |
@slackhappy thanks for the contribution. I pushed the changes to npm: https://www.npmjs.com/package/cld?activeTab=versions |
@dachev, thank you so much! |
Support
CLD2::kCLDFlagBestEffort
for shorter textHelps with issues like #78 for example:
without bestEffort
with bestEffort:
Or #31
with bestEffort:
#33
with bestEffort: