Use default config for sites which do not have a zone #166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have configured zones as described in https://github.com/dachcom-digital/pimcore-i18n/blob/master/docs/20_Zones.md and afterwards add a new site
/new-site
, add localization pages like/new-site/de
and assign it a language, you will get the error message:Although
pimcore-i18n/src/Builder/ZoneBuilder.php
Lines 57 to 60 in c7381c1
// no valid zone found. use default one.
, it throws the exception which does not fall back to using default zone.With this PR a temporary zone based on the default configuration will get created for the main domain of the site.