Skip to content

Commit

Permalink
fix exception handler priority
Browse files Browse the repository at this point in the history
  • Loading branch information
solverat committed May 13, 2024
1 parent 7fb5f10 commit 86fb9ed
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 7 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/codeception.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
name: Codeception
on:
push:
branches: [ 'master' ]
branches: [ '4.x' ]
pull_request:
branches: [ 'master' ]
branches: [ '4.x' ]

jobs:
codeception:
Expand Down Expand Up @@ -120,6 +120,7 @@ jobs:
TEST_PIMCORE_VERSION: ${{ matrix.pimcore }}
TEST_SYMFONY_VERSION: ${{ matrix.symfony }}
run: |
sed -i 's|"require-dev": {|"conflict": {"league/csv": ">=9.11.0"},\n "require-dev": {|' ${{ github.workspace }}/lib/test-bundle/composer.json
chmod +x ./pimcore-codeception-framework/src/_etc/scripts/composer.sh
./pimcore-codeception-framework/src/_etc/scripts/composer.sh
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/ecs.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
name: Easy Coding Standards
on:
push:
branches: [ 'master' ]
branches: [ '4.x' ]
pull_request:
branches: [ 'master' ]
branches: [ '4.x' ]

jobs:
ecs:
Expand Down Expand Up @@ -103,6 +103,7 @@ jobs:
TEST_PIMCORE_VERSION: ${{ matrix.pimcore }}
TEST_SYMFONY_VERSION: ${{ matrix.symfony }}
run: |
sed -i 's|"require-dev": {|"conflict": {"league/csv": ">=9.11.0"},\n "require-dev": {|' ${{ github.workspace }}/lib/test-bundle/composer.json
chmod +x ./pimcore-codeception-framework/src/_etc/scripts/composer.sh
./pimcore-codeception-framework/src/_etc/scripts/composer.sh
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/php-stan.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
name: PHP Stan
on:
push:
branches: [ 'master' ]
branches: [ '4.x' ]
pull_request:
branches: [ 'master' ]
branches: [ '4.x' ]

jobs:
stan:
Expand Down Expand Up @@ -103,6 +103,7 @@ jobs:
TEST_PIMCORE_VERSION: ${{ matrix.pimcore }}
TEST_SYMFONY_VERSION: ${{ matrix.symfony }}
run: |
sed -i 's|"require-dev": {|"conflict": {"league/csv": ">=9.11.0"},\n "require-dev": {|' ${{ github.workspace }}/lib/test-bundle/composer.json
chmod +x ./pimcore-codeception-framework/src/_etc/scripts/composer.sh
./pimcore-codeception-framework/src/_etc/scripts/composer.sh
Expand Down
3 changes: 3 additions & 0 deletions UPGRADE.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Upgrade Notes

## 4.1.10
- [BUGFIX] Fix exception handler priority to prevent authentication exception hijacking

## 4.1.9
- [BUGFIX] Move preview listener to earlier state to allow static route preview with restricted sites

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public function __construct(
public static function getSubscribedEvents(): array
{
return [
KernelEvents::EXCEPTION => ['onKernelException', 10]
KernelEvents::EXCEPTION => 'onKernelException'
];
}

Expand Down

0 comments on commit 86fb9ed

Please sign in to comment.