finished ex1 ;) #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ap1-summer2020-biu
requested changes
Aug 19, 2020
| @@ -1,38 +1,38 @@ | |||
| # Prerequisites | |||
There was a problem hiding this comment.
Don't change CR/LF - it creates unrequired diff
| @@ -0,0 +1,40 @@ | |||
| #include "ErrorCode.h" | |||
There was a problem hiding this comment.
Remove documentation from C file (C15)
| * @param[in] code the error code. | ||
| * @return whether the error code indicates a success or not. | ||
| */ | ||
| bool error_isSuccess(ErrorCode code) { |
There was a problem hiding this comment.
Parameters are not constants (C2)
| * @return whether the error code indicates a success or not. | ||
| */ | ||
| bool error_isSuccess(ErrorCode code) { | ||
| if (code == ERROR_SUCCESS) { |
There was a problem hiding this comment.
return code == ERROR_SUCCESS
| * @return const char* the textual representation of the error code. | ||
| */ | ||
| const char *error_getErrorMessage(ErrorCode code) { | ||
| switch (code) { |
There was a problem hiding this comment.
Bloated code (C11)
| mat->values[i] = (double *)calloc(width, sizeof(double)); | ||
| if (mat->values[i] == NULL) { | ||
| for (int j = 0; j < i; j++) { | ||
| free(mat->values[j]); |
| free(mat); | ||
| return ERROR_ALLOCATION_FAILED; | ||
| } | ||
| for (int i = 0; i < mat->height; i++) { |
There was a problem hiding this comment.
Postfix increment (C5)
| return ERROR_NULL; | ||
| } | ||
|
|
||
| uint32_t h = source->height, w = source->width; |
There was a problem hiding this comment.
h and w are generally not very good nor indicative names for variables
| if (matrix == NULL) { | ||
| return ERROR_NULL; | ||
| } | ||
| int row = (int)rowIndex, col = (int)colIndex; |
| @@ -0,0 +1,113 @@ | |||
| #pragma once | |||
There was a problem hiding this comment.
Shared resources not in master (G7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.