Properly handle :cq #269
Closed
Properly handle :cq #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the user invokes :cq, this causes Neovim to exit unsuccessfully. This is important if the user wishes to abort a Git commit message, or in other situations where the operation is aborted when the editor exits unsuccessfully. Let's make this work by listening to the VimLeavePre autocommand and then reading the v:exiting code, which indicates the exit status with which Neovim is exiting. Save this into the state, and then when the detach callback is called, exit with the appropriate status. Note that we use a separate Arc/Mutex construction here because otherwise we need to borrow the state mutably, and at that point it's already borrowed and we panic. This allows us to not need to do that, and henceforth avoid the panic.
|
This project is abandoned, but I'd recommend checking out the fork by @Lyude https://github.com/Lyude/neovim-gtk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user invokes
:cq, this causes Neovim to exit unsuccessfully. This is important if the user wishes to abort a Git commit message, or in other situations where the operation is aborted when the editor exits unsuccessfully.Let's make this work by listening to the VimLeavePre autocommand and then reading the v:exiting code, which indicates the exit status with which Neovim is exiting. Save this into the state, and then when the detach callback is called, exit with the appropriate status.
Note that we use a separate Arc/Mutex construction here because otherwise we need to borrow the state mutably, and at that point it's already borrowed and we panic. This allows us to not need to do that, and henceforth avoid the panic.
Fixes #266