drv: set default for option restore-success-on-close to false

as CTA version 5.10.10 is already released and deployed.
dCache · Jul 16, 2024 · f959703 · f959703
1 parent 8efa15b
commit f959703
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 13 deletions.
diff --git a/README.md b/README.md
@@ -83,18 +83,18 @@ queue define class -expire=0 -pending=0 -total=0 -open <hsmType> *
 
 ### The available configuration options:
 
-| Name                 | Description                                                                                       | required | default    |
-|:---------------------|:--------------------------------------------------------------------------------------------------|---------:|------------|
-| cta-instance-name    | The dCache instance name configured in CTA                                                        |      yes | -          |
-| cta-frontend-addr    | The CTA `cta-dcache` endpoint                                                                     |      yes | -          |
-| cta-user             | The dCache instance associated user in CTA                                                        |      yes | -          |
-| cta-group            | The dCache instance associated group in CTA                                                       |      yes | -          |
-| cta-ca-chain         | The path to CA root chain for use with TLS                                                        |       no | -          |
-| cta-use-tls          | A switch (true/false) to enable TLS for CTA control connection                                    |       no | `false`    |
-| cta-frontend-timeout | How log dCache waits in seconds for CTA frontend to reply                                         |       no | 30         |
-| io-endpoint          | The hostname or IP offered by dCache for IO by CTA                                                |       no | `hostname` |
-| io-port              | The TCP port offered by dCache for IO by CTA                                                      |       no | -          |
-| restore-success-on-close | A swith to enable/disable success on close for restores. Backward compatibility with CTA pre-5.11 |       no | `true`     |
+| Name                 | Description                                                                                 | required | default    |
+|:---------------------|:--------------------------------------------------------------------------------------------|---------:|------------|
+| cta-instance-name    | The dCache instance name configured in CTA                                                  |      yes | -          |
+| cta-frontend-addr    | The CTA `cta-dcache` endpoint                                                               |      yes | -          |
+| cta-user             | The dCache instance associated user in CTA                                                  |      yes | -          |
+| cta-group            | The dCache instance associated group in CTA                                                 |      yes | -          |
+| cta-ca-chain         | The path to CA root chain for use with TLS                                                  |       no | -          |
+| cta-use-tls          | A switch (true/false) to enable TLS for CTA control connection                              |       no | `false`    |
+| cta-frontend-timeout | How log dCache waits in seconds for CTA frontend to reply                                   |       no | 30         |
+| io-endpoint          | The hostname or IP offered by dCache for IO by CTA                                          |       no | `hostname` |
+| io-port              | The TCP port offered by dCache for IO by CTA                                                |       no | -          |
+| restore-success-on-close | Enable/disable `success on close` for restores. Backward compatibility with CTA pre-5.10.10 |       no | `false`    |
 
 ## Acknowledgements
 

diff --git a/src/main/java/org/dcache/nearline/cta/CtaNearlineStorage.java b/src/main/java/org/dcache/nearline/cta/CtaNearlineStorage.java
@@ -450,7 +450,7 @@ public void configure(Map<String, String> properties) throws IllegalArgumentExce
             ctaRequestTimeoutInSec = Integer.parseInt(timeoutString);
         }
 
-        success_on_close = Boolean.parseBoolean(properties.getOrDefault(RESTORE_SUCCESS_ON_CLOSE, "true"));
+        success_on_close = Boolean.parseBoolean(properties.getOrDefault(RESTORE_SUCCESS_ON_CLOSE, "false"));
     }
 
     @Override