Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dbp 333 expand the terraform module for autoscaling functionality #17

Merged
merged 100 commits into from
Nov 30, 2023
Merged

Dbp 333 expand the terraform module for autoscaling functionality #17

merged 100 commits into from
Nov 30, 2023

Conversation

maxi418
Copy link
Contributor

@maxi418 maxi418 commented Nov 27, 2023

Description

Links to Tickets or other PRs

Notes

Approval for review

  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

marhode added 30 commits October 27, 2023 16:07
@marhode
Initial commit with changes to introduce auto scaling node pools
a8ed6b9
@marhode
Test changes
91fd096
@marhode
Made changes to the nodepools for scaling testing
fd8f71c
@marhode
Additions to test the terraform nodepool creation
2fb90f7
@marhode
Fix of error due to variable definition and expansion of the for loop…
c002756 
… to match requirements
@marhode
Fix for object creation constructor
4bcf10f
@marhode
Terraform function call fix
f12b253
@marhode
Fixed the ip pool creation the new nodepool creation
5ddddaa
@marhode
Fix variables in nodepool object
a3afb82
@marhode
Fixed typo
8c72f61
@marhode
Removed count for now
471d36f
@marhode
Fixes towards legacy object creation to be filled with correct variables
25893ed
@marhode
Changed definition of custom_nodepools in locals
4008c1d
@marhode
Typo in availabilityzone fixed
ba91cb8
@marhode
Rename ippools resource
4986ce1
@marhode
Fixed naming of ippools
65d0b31
@marhode
Enable to use both legacy and scaling nodepools
8482d5a
@marhode
Fixes to variable scopes
873022b
@marhode
Fix to the legacy object for merging
bdc44ce
@marhode
Test for merge of legacy and scaling lists
d0f1965
@marhode
Changed merge to concat of two lists
badd726
@marhode
turn object tolist for concat
2e044d1
@marhode
Fixed syntax error
a4387a5
@marhode
Test for conditional fix
7ef35ab
@marhode
Try setunion to combine both object lists together
41e8294
@marhode
Added missing variables to object
fae9c1d
@marhode
added tolist
613e6e8
@marhode
Fixed associated lans
2106b91
@marhode
Small readability adjustments
5512de3
@marhode
Testing purpose legacy min and max node count equals node count
8bba887
maxi418 and others added 9 commits November 30, 2023 09:50
@maxi418
Merge branch 'DBP-333-Expand-the-terraform-module-for-autoscaling-fun…
68bb462 
…ctionality' of github.com:dBildungsplattform/infra-terraform-modules into DBP-333-Expand-the-terraform-module-for-autoscaling-functionality
@maxi418
fixed public ips for empty list
cb399e1
@maxi418
added output for ippools
5735a4a
@github-actions
terraform-docs: automated action
abf3376
@maxi418
updated ip output
87c71f6
@maxi418
Merge branch 'DBP-333-Expand-the-terraform-module-for-autoscaling-fun…
430fc11 
…ctionality' of github.com:dBildungsplattform/infra-terraform-modules into DBP-333-Expand-the-terraform-module-for-autoscaling-functionality
@maxi418
extended public ips condition for custom nodes
90c590c
@maxi418
fixed ippools if no public ippools needed
80368f2
@maxi418
fix public ips
d72dac9
@maxi418
cleanup
4a46930
@maxi418
Merge branch 'DBP-333-Expand-the-terraform-module-for-autoscaling-fun…
d354edd 
…ctionality' of github.com:dBildungsplattform/infra-terraform-modules into DBP-333-Expand-the-terraform-module-for-autoscaling-functionality
@maxi418 maxi418 merged commit 5e12b8e into main Nov 30, 2023
2 checks passed
@maxi418 maxi418 deleted the DBP-333-Expand-the-terraform-module-for-autoscaling-functionality branch November 30, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aimee-889 aimee-889 aimee-889 left review comments

@simoncolincap simoncolincap simoncolincap approved these changes

Assignees

@marhode marhode

@maxi418 maxi418

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxi418 @simoncolincap @aimee-889 @marhode