Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBP-285-research-loadbalancer #10

Merged
merged 14 commits into from
Oct 18, 2023
Merged

Conversation

aimee-889
Copy link
Contributor

@aimee-889 aimee-889 commented Oct 12, 2023

Description

extend module cidr-workaround so i know the ips of Node Lans
Add IONOS Application Loadbalancer Module

Links to Tickets or other PRs

Notes

Approval for review

  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@aimee-889 aimee-889 self-assigned this Oct 12, 2023
@aimee-889 aimee-889 changed the title extend ionos-cidr-workaround DBP-285-research-loadbalancer Oct 12, 2023
@aimee-889 aimee-889 requested a review from a team October 13, 2023 06:56
modules/ionos-application-loadbalancer/main.tf Outdated Show resolved Hide resolved
modules/ionos-application-loadbalancer/main.tf Outdated Show resolved Hide resolved
modules/ionos-application-loadbalancer/main.tf Outdated Show resolved Hide resolved
modules/ionos-application-loadbalancer/main.tf Outdated Show resolved Hide resolved
modules/ionos-application-loadbalancer/main.tf Outdated Show resolved Hide resolved
modules/ionos-application-loadbalancer/output.tf Outdated Show resolved Hide resolved
prefix = format("%s/24", data.ionoscloud_servers.k8s_nodes.servers[0].nics[local.nicIndex].ips[0])
nicIndex = index(data.ionoscloud_servers.k8s_node.servers[0].nics.*.lan, tonumber(var.lan_id))
prefix = format("%s/24", data.ionoscloud_servers.k8s_node.servers[0].nics[local.nicIndex].ips[0])
node_lan_ips = flatten(data.ionoscloud_servers.k8s_nodes[*].servers[*].nics[local.nicIndex].ips[0])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this we get the ips of the alb target lan. These ips were initially for the two nodes 10.7.224.11 and 10.7.224.13, but after maintenance, they changed to 11 and 12.
I do not know why ip 12 was not at first assigned but 13. All other clusters seem not to skip any numbers. Maybe this is only something that happens when setting up a cluster/lan and will get standardized after maintenance?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the time being we will be careful when adding application load balancer target lans to nodes, especially if it is is a prod instance, and see which values they will receive. If they should not match after a maintenance a terraform apply will update the ips. In the meantime we have enabled a health check on the targets in the target group. So worst case is that the traffic will only be forwarded to half the nodes.

@aimee-889 aimee-889 requested a review from dimapin October 16, 2023 11:22
@aimee-889 aimee-889 requested a review from dimapin October 17, 2023 08:30
@aimee-889 aimee-889 dismissed dimapin’s stale review October 18, 2023 17:28

fixed points - want to merge now

@aimee-889 aimee-889 merged commit 1e6665f into main Oct 18, 2023
2 checks passed
@aimee-889 aimee-889 deleted the DBP-285-research-loadbalancer branch May 28, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants