Spsh-1574: Fortschrittsanzeige & Bulk-Transaktionen #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tory of imports and import transactions updates.
…ed the integration tests.
…max number of users is checked
…les for the pipeline
…ems, added totalDataItemImported in the importvorgang entity and refactored import-workflow and the import event handler.
…e totalDataItemImported value
marode-cap
requested changes
Dec 18, 2024
Comment on lines
142
to
153
| throw new ImportDomainError( | ||
| `The creation of person with personenkontexte for the import transaction:${importVorgang.id} failed`, | ||
| importVorgang.id, | ||
| ); | ||
| } | ||
|
|
||
| if (!savedPersonWithPersonenkontext.person.newPassword) { | ||
| return this.logger.error( | ||
| `Person with ID ${savedPersonWithPersonenkontext.person.id} has no start password!`, | ||
| this.logger.error(`Person with ID ${savedPersonWithPersonenkontext.person.id} has no start password!`); | ||
|
|
||
| throw new ImportDomainError( | ||
| `The creation for a password for the person with ID ${savedPersonWithPersonenkontext.person.id} for the import transaction:${importVorgang.id} has failed`, | ||
| importVorgang.id, |
There was a problem hiding this comment.
If these errors occur, they aren't handled at all as far as I can see. They will just be logged and the import will never finish?
There was a problem hiding this comment.
Great observation, i set the status to FAILED, when the FE requests the import status it will see that the import has failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Links to Tickets or other pull requests
https://ticketsystem.dbildungscloud.de/browse/SPSH-1574
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review