SPSH:1634: Disable implicit type-conversion in config-loader #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marode-cap
approved these changes
Dec 13, 2024
kristoff-kiefer
added a commit
that referenced
this pull request
Dec 18, 2024
* implementing Schulzuweisung to ldap * adding containsAnyCurrentPKWithRollenartLehr() funktion to personenkontext-updated.events * fix tests * remove comment * implementing tests for removePersonFromGroup * adding tests for addPersonToGroup * copying ldap event handler tests from main * adding !pk.orgaKennung tests * add test for addPersonToGroup in createLehrer * fixing tests for addPersonToGroup * adjust error handling * test for new error handling * rename * no async inside Promise * log failed promise results * remove unnecessary import * remove logging because error message isnt present * fix test * add logging * Spsh 1580 (#831) Spsh 1580 * Fixed rolle name (#840) * refactoring * SPSH-1584: OX: E-Mail Adresse bei Namensänderung wird nicht angepasst (#826) * adjust OXUserChange (renaming user) to set referrer as OxUserName also adjust evnet regarding ID_OX in KC * expect more info-logging in test cases for OxEventHandler * SPSH-1592 (#828) * add personID to some logs in OxEventHandler and EmailEventHandler * log warning if multiple REQUESTED emailAddresses can be found for person * log warning when multiple REQUESTED emailAddresses found for personId * SPSH-1544: UEM Inbetriebnahme-Passwort erzeugen (#820) * rm PersonRepository-ref in LdapClientSvc, adjust Email-events to contain referrer, add resetUEMPasswordByPersonId in PersonController, add PersonReferrer-type * fix existing test cases * add test cases after adjusting LDAPClientSvc * remove dead imports and comments * add RollenArt to DBiamPersonenzuordnungResponse * remove StepUp-Guard for Reset-UEM-password * allow Lehrer to use UEM-password-reset for themselves * undo StepUpGuard-disabling for creating person with kontexte via POST * adjust i18 for Person-UEM-Password, adjust test cases --------- Co-authored-by: Youssef Bouchara <[email protected]> * SPSH-1626 itslearning correlation-IDs (#839) * Add syncID to itslearning requests and logs * Fix linter warnings * Fix coverage * fixing addPersonToGroup * SPSH-1583: Refaktorisierung OX-User-Blacklist (#829) * create OxUserBlacklistEntry, OxUserBlacklistRepo * use OxUserBlacklistRepo in UsernameGeneratorService * fix test-cases which use UsernameGenerator to provide OxUserBlacklistRepo * add test-cases for OxUserBlacklistRepo * fix imports in modules and test-files * rm unused import * refactor LDAP client service and event handler for improved organization and member checks * implementing uid rename in groups by PersonRenamedEvent * fixing tests for removePersonFromGroup * fixing tests * fixing coverage * test coverage * implementing base_dn config * linting * fix configloader tests * fixing coverage * fixing coverage * adding dynamic root group * refactoring * refactoring * adjust config-loader to NOT convert values implicitly (#841) * refactoring values.yml * handling error when deleting non existing Lehrer * fix coverage --------- Co-authored-by: Timo K <[email protected]> Co-authored-by: Youssef Bouchara <[email protected]> Co-authored-by: Cornelius <[email protected]> Co-authored-by: Marvin Rode (Cap) <[email protected]> Co-authored-by: Kristoff Kiefer <[email protected]>
kristoff-kiefer
added a commit
that referenced
this pull request
Dec 18, 2024
* Spsh 1580 (#831) Spsh 1580 * Fixed rolle name (#840) * SPSH-1584: OX: E-Mail Adresse bei Namensänderung wird nicht angepasst (#826) * adjust OXUserChange (renaming user) to set referrer as OxUserName also adjust evnet regarding ID_OX in KC * expect more info-logging in test cases for OxEventHandler * SPSH-1592 (#828) * add personID to some logs in OxEventHandler and EmailEventHandler * log warning if multiple REQUESTED emailAddresses can be found for person * log warning when multiple REQUESTED emailAddresses found for personId * SPSH-1544: UEM Inbetriebnahme-Passwort erzeugen (#820) * rm PersonRepository-ref in LdapClientSvc, adjust Email-events to contain referrer, add resetUEMPasswordByPersonId in PersonController, add PersonReferrer-type * fix existing test cases * add test cases after adjusting LDAPClientSvc * remove dead imports and comments * add RollenArt to DBiamPersonenzuordnungResponse * remove StepUp-Guard for Reset-UEM-password * allow Lehrer to use UEM-password-reset for themselves * undo StepUpGuard-disabling for creating person with kontexte via POST * adjust i18 for Person-UEM-Password, adjust test cases --------- Co-authored-by: Youssef Bouchara <[email protected]> * SPSH-1626 itslearning correlation-IDs (#839) * Add syncID to itslearning requests and logs * Fix linter warnings * Fix coverage * SPSH-1583: Refaktorisierung OX-User-Blacklist (#829) * create OxUserBlacklistEntry, OxUserBlacklistRepo * use OxUserBlacklistRepo in UsernameGeneratorService * fix test-cases which use UsernameGenerator to provide OxUserBlacklistRepo * add test-cases for OxUserBlacklistRepo * fix imports in modules and test-files * rm unused import * adjust config-loader to NOT convert values implicitly (#841) --------- Co-authored-by: Timo K <[email protected]> Co-authored-by: Youssef Bouchara <[email protected]> Co-authored-by: Cornelius <[email protected]> Co-authored-by: Marvin Rode (Cap) <[email protected]>
kristoff-kiefer
added a commit
that referenced
this pull request
Dec 18, 2024
* implementing Schulzuweisung to ldap * adding containsAnyCurrentPKWithRollenartLehr() funktion to personenkontext-updated.events * fix tests * remove comment * implementing tests for removePersonFromGroup * adding tests for addPersonToGroup * copying ldap event handler tests from main * adding !pk.orgaKennung tests * add test for addPersonToGroup in createLehrer * fixing tests for addPersonToGroup * adjust error handling * test for new error handling * rename * no async inside Promise * log failed promise results * remove unnecessary import * remove logging because error message isnt present * fix test * add logging * Spsh 1580 (#831) Spsh 1580 * Fixed rolle name (#840) * refactoring * SPSH-1584: OX: E-Mail Adresse bei Namensänderung wird nicht angepasst (#826) * adjust OXUserChange (renaming user) to set referrer as OxUserName also adjust evnet regarding ID_OX in KC * expect more info-logging in test cases for OxEventHandler * SPSH-1592 (#828) * add personID to some logs in OxEventHandler and EmailEventHandler * log warning if multiple REQUESTED emailAddresses can be found for person * log warning when multiple REQUESTED emailAddresses found for personId * SPSH-1544: UEM Inbetriebnahme-Passwort erzeugen (#820) * rm PersonRepository-ref in LdapClientSvc, adjust Email-events to contain referrer, add resetUEMPasswordByPersonId in PersonController, add PersonReferrer-type * fix existing test cases * add test cases after adjusting LDAPClientSvc * remove dead imports and comments * add RollenArt to DBiamPersonenzuordnungResponse * remove StepUp-Guard for Reset-UEM-password * allow Lehrer to use UEM-password-reset for themselves * undo StepUpGuard-disabling for creating person with kontexte via POST * adjust i18 for Person-UEM-Password, adjust test cases --------- Co-authored-by: Youssef Bouchara <[email protected]> * SPSH-1626 itslearning correlation-IDs (#839) * Add syncID to itslearning requests and logs * Fix linter warnings * Fix coverage * fixing addPersonToGroup * SPSH-1583: Refaktorisierung OX-User-Blacklist (#829) * create OxUserBlacklistEntry, OxUserBlacklistRepo * use OxUserBlacklistRepo in UsernameGeneratorService * fix test-cases which use UsernameGenerator to provide OxUserBlacklistRepo * add test-cases for OxUserBlacklistRepo * fix imports in modules and test-files * rm unused import * refactor LDAP client service and event handler for improved organization and member checks * implementing uid rename in groups by PersonRenamedEvent * fixing tests for removePersonFromGroup * fixing tests * fixing coverage * test coverage * implementing base_dn config * linting * fix configloader tests * fixing coverage * fixing coverage * adding dynamic root group * refactoring * refactoring * adjust config-loader to NOT convert values implicitly (#841) * refactoring values.yml * handling error when deleting non existing Lehrer * fix coverage --------- Co-authored-by: Alexander Ungefug <[email protected]> Co-authored-by: Timo K <[email protected]> Co-authored-by: Youssef Bouchara <[email protected]> Co-authored-by: Cornelius <[email protected]> Co-authored-by: Kristoff Kiefer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable implicit type-conversion in config-loader to avoid errors e.g. when using a string as boolean in config it always evaluates to true, so "false" is evaluated as True without any errors or warnings at the moment
Links to Tickets or other pull requests
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review