Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPSH-1626 itslearning correlation-IDs #839

Merged
merged 5 commits into from
Dec 12, 2024
Merged

SPSH-1626 itslearning correlation-IDs #839

merged 5 commits into from
Dec 12, 2024

Conversation

marode-cap
Copy link
Contributor

Description

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

@marode-cap marode-cap marked this pull request as ready for review December 11, 2024 09:21
@clauyan clauyan self-requested a review December 11, 2024 10:25
clauyan
clauyan approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@clauyan clauyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this functionality for other external systems? I think it might be useful to have some kind of tracing/correlation mechanism in our logger implementation. Maybe a follow-up ticket? What do you think?

Approved with the changes/clarifications regarding names above.

src/modules/itslearning/itslearning.service.ts Show resolved Hide resolved
src/modules/itslearning/event-handlers/itslearning-persons.event-handler.ts Show resolved Hide resolved
@marode-cap
Copy link
Contributor Author

Do we need this functionality for other external systems? I think it might be useful to have some kind of tracing/correlation mechanism in our logger implementation. Maybe a follow-up ticket? What do you think?

Approved with the changes/clarifications regarding names above.

Kristoff and I already talked and the goal would be to have per-request correlation IDs. When that comes to fruition, we can just use that ID in the event instead of generating it.

@marode-cap marode-cap merged commit ae19e32 into release-0101 Dec 12, 2024
31 checks passed
@marode-cap marode-cap deleted the spsh-1626 branch December 12, 2024 11:10
kristoff-kiefer added a commit that referenced this pull request Dec 18, 2024
@AlexanderUngefug @tikle-cap
@YoussefBouch @DPDS93CT @marode-cap @kristoff-kiefer
Spsh 1529 (#843)
f276f87 
* implementing Schulzuweisung to ldap

* adding  containsAnyCurrentPKWithRollenartLehr() funktion to personenkontext-updated.events

* fix tests

* remove comment

* implementing tests for removePersonFromGroup

* adding tests for addPersonToGroup

* copying ldap event handler tests from main

* adding !pk.orgaKennung tests

* add test for addPersonToGroup in createLehrer

* fixing tests for addPersonToGroup

* adjust error handling

* test for new error handling

* rename

* no async inside Promise

* log failed promise results

* remove unnecessary import

* remove logging because error message isnt present

* fix test

* add logging

* Spsh 1580 (#831)

Spsh 1580

* Fixed rolle name (#840)

* refactoring

* SPSH-1584: OX: E-Mail Adresse bei Namensänderung wird nicht angepasst (#826)

* adjust OXUserChange (renaming user) to set referrer as OxUserName also adjust evnet regarding ID_OX in KC

* expect more info-logging in test cases for OxEventHandler

* SPSH-1592 (#828)

* add personID to some logs in OxEventHandler and EmailEventHandler

* log warning if multiple REQUESTED emailAddresses can be found for person

* log warning when multiple REQUESTED emailAddresses found for personId

* SPSH-1544: UEM Inbetriebnahme-Passwort erzeugen (#820)

* rm PersonRepository-ref in LdapClientSvc, adjust Email-events to contain referrer, add resetUEMPasswordByPersonId in PersonController, add PersonReferrer-type

* fix existing test cases

* add test cases after adjusting LDAPClientSvc

* remove dead imports and comments

* add RollenArt to DBiamPersonenzuordnungResponse

* remove StepUp-Guard for Reset-UEM-password

* allow Lehrer to use UEM-password-reset for themselves

* undo StepUpGuard-disabling for creating person with kontexte via POST

* adjust i18 for Person-UEM-Password, adjust test cases

---------

Co-authored-by: Youssef Bouchara <[email protected]>

* SPSH-1626 itslearning correlation-IDs (#839)

* Add syncID to itslearning requests and logs

* Fix linter warnings

* Fix coverage

* fixing addPersonToGroup

* SPSH-1583: Refaktorisierung OX-User-Blacklist (#829)

* create OxUserBlacklistEntry, OxUserBlacklistRepo

* use OxUserBlacklistRepo in UsernameGeneratorService

* fix test-cases which use UsernameGenerator to provide OxUserBlacklistRepo

* add test-cases for OxUserBlacklistRepo

* fix imports in modules and test-files

* rm unused import

* refactor LDAP client service and event handler for improved organization and member checks

* implementing uid rename in groups by PersonRenamedEvent

* fixing tests for removePersonFromGroup

* fixing tests

* fixing coverage

* test coverage

* implementing base_dn config

* linting

* fix configloader tests

* fixing coverage

* fixing coverage

* adding dynamic root group

* refactoring

* refactoring

* adjust config-loader to NOT convert values implicitly (#841)

* refactoring values.yml

* handling error when deleting non existing Lehrer

* fix coverage

---------

Co-authored-by: Timo K <[email protected]>
Co-authored-by: Youssef Bouchara <[email protected]>
Co-authored-by: Cornelius <[email protected]>
Co-authored-by: Marvin Rode (Cap) <[email protected]>
Co-authored-by: Kristoff Kiefer <[email protected]>
kristoff-kiefer added a commit that referenced this pull request Dec 18, 2024
@kristoff-kiefer @tikle-cap
@YoussefBouch @DPDS93CT @marode-cap
Merge Release 1.1 back into main (#850)
367212f 
* Spsh 1580 (#831)

Spsh 1580

* Fixed rolle name (#840)

* SPSH-1584: OX: E-Mail Adresse bei Namensänderung wird nicht angepasst (#826)

* adjust OXUserChange (renaming user) to set referrer as OxUserName also adjust evnet regarding ID_OX in KC

* expect more info-logging in test cases for OxEventHandler

* SPSH-1592 (#828)

* add personID to some logs in OxEventHandler and EmailEventHandler

* log warning if multiple REQUESTED emailAddresses can be found for person

* log warning when multiple REQUESTED emailAddresses found for personId

* SPSH-1544: UEM Inbetriebnahme-Passwort erzeugen (#820)

* rm PersonRepository-ref in LdapClientSvc, adjust Email-events to contain referrer, add resetUEMPasswordByPersonId in PersonController, add PersonReferrer-type

* fix existing test cases

* add test cases after adjusting LDAPClientSvc

* remove dead imports and comments

* add RollenArt to DBiamPersonenzuordnungResponse

* remove StepUp-Guard for Reset-UEM-password

* allow Lehrer to use UEM-password-reset for themselves

* undo StepUpGuard-disabling for creating person with kontexte via POST

* adjust i18 for Person-UEM-Password, adjust test cases

---------

Co-authored-by: Youssef Bouchara <[email protected]>

* SPSH-1626 itslearning correlation-IDs (#839)

* Add syncID to itslearning requests and logs

* Fix linter warnings

* Fix coverage

* SPSH-1583: Refaktorisierung OX-User-Blacklist (#829)

* create OxUserBlacklistEntry, OxUserBlacklistRepo

* use OxUserBlacklistRepo in UsernameGeneratorService

* fix test-cases which use UsernameGenerator to provide OxUserBlacklistRepo

* add test-cases for OxUserBlacklistRepo

* fix imports in modules and test-files

* rm unused import

* adjust config-loader to NOT convert values implicitly (#841)

---------

Co-authored-by: Timo K <[email protected]>
Co-authored-by: Youssef Bouchara <[email protected]>
Co-authored-by: Cornelius <[email protected]>
Co-authored-by: Marvin Rode (Cap) <[email protected]>
kristoff-kiefer added a commit that referenced this pull request Dec 18, 2024
@marode-cap @AlexanderUngefug
@tikle-cap @YoussefBouch @DPDS93CT @kristoff-kiefer
Spsh 1529 (#851)
3555dd5 
* implementing Schulzuweisung to ldap

* adding  containsAnyCurrentPKWithRollenartLehr() funktion to personenkontext-updated.events

* fix tests

* remove comment

* implementing tests for removePersonFromGroup

* adding tests for addPersonToGroup

* copying ldap event handler tests from main

* adding !pk.orgaKennung tests

* add test for addPersonToGroup in createLehrer

* fixing tests for addPersonToGroup

* adjust error handling

* test for new error handling

* rename

* no async inside Promise

* log failed promise results

* remove unnecessary import

* remove logging because error message isnt present

* fix test

* add logging

* Spsh 1580 (#831)

Spsh 1580

* Fixed rolle name (#840)

* refactoring

* SPSH-1584: OX: E-Mail Adresse bei Namensänderung wird nicht angepasst (#826)

* adjust OXUserChange (renaming user) to set referrer as OxUserName also adjust evnet regarding ID_OX in KC

* expect more info-logging in test cases for OxEventHandler

* SPSH-1592 (#828)

* add personID to some logs in OxEventHandler and EmailEventHandler

* log warning if multiple REQUESTED emailAddresses can be found for person

* log warning when multiple REQUESTED emailAddresses found for personId

* SPSH-1544: UEM Inbetriebnahme-Passwort erzeugen (#820)

* rm PersonRepository-ref in LdapClientSvc, adjust Email-events to contain referrer, add resetUEMPasswordByPersonId in PersonController, add PersonReferrer-type

* fix existing test cases

* add test cases after adjusting LDAPClientSvc

* remove dead imports and comments

* add RollenArt to DBiamPersonenzuordnungResponse

* remove StepUp-Guard for Reset-UEM-password

* allow Lehrer to use UEM-password-reset for themselves

* undo StepUpGuard-disabling for creating person with kontexte via POST

* adjust i18 for Person-UEM-Password, adjust test cases

---------

Co-authored-by: Youssef Bouchara <[email protected]>

* SPSH-1626 itslearning correlation-IDs (#839)

* Add syncID to itslearning requests and logs

* Fix linter warnings

* Fix coverage

* fixing addPersonToGroup

* SPSH-1583: Refaktorisierung OX-User-Blacklist (#829)

* create OxUserBlacklistEntry, OxUserBlacklistRepo

* use OxUserBlacklistRepo in UsernameGeneratorService

* fix test-cases which use UsernameGenerator to provide OxUserBlacklistRepo

* add test-cases for OxUserBlacklistRepo

* fix imports in modules and test-files

* rm unused import

* refactor LDAP client service and event handler for improved organization and member checks

* implementing uid rename in groups by PersonRenamedEvent

* fixing tests for removePersonFromGroup

* fixing tests

* fixing coverage

* test coverage

* implementing base_dn config

* linting

* fix configloader tests

* fixing coverage

* fixing coverage

* adding dynamic root group

* refactoring

* refactoring

* adjust config-loader to NOT convert values implicitly (#841)

* refactoring values.yml

* handling error when deleting non existing Lehrer

* fix coverage

---------

Co-authored-by: Alexander Ungefug <[email protected]>
Co-authored-by: Timo K <[email protected]>
Co-authored-by: Youssef Bouchara <[email protected]>
Co-authored-by: Cornelius <[email protected]>
Co-authored-by: Kristoff Kiefer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clauyan clauyan clauyan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marode-cap @clauyan