EW-644 modifed schulconnex error

dBildungsplattform · Nov 17, 2023 · d425ccd · d425ccd
1 parent 6abf621
commit d425ccd
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/src/shared/error/schulconnex-validation-error.filter.ts b/src/shared/error/schulconnex-validation-error.filter.ts
@@ -5,7 +5,7 @@ import { HttpArgumentsHost } from '@nestjs/common/interfaces/index.js';
 import { Response } from 'express';
 
 export type SchulConnexError = {
-    statusCode?: number;
+    statusCode: number;
     subCode: string;
     title: string;
     description: string;

diff --git a/src/shared/validation/global-validation.pipe.ts b/src/shared/validation/global-validation.pipe.ts
@@ -21,7 +21,6 @@ export class GlobalValidationPipe extends ValidationPipe {
             whitelist: true, // only pass valid @ApiProperty-decorated DTO properties, remove others
             forbidNonWhitelisted: false, // additional params are just skipped (required when extracting multiple DTO from single query)
             forbidUnknownValues: true,
-            // TODO: create types for the exception factory: EW-???
             exceptionFactory: (errors: ValidationError[]) => new DetailedValidationError(errors),
         });
     }