fix types in tests

dBildungsplattform · Sep 9, 2024 · 40ade2c · 40ade2c
1 parent 0ddc16e
commit 40ade2c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/src/modules/authentication/api/authentication.controller.integration-spec.ts b/src/modules/authentication/api/authentication.controller.integration-spec.ts
@@ -258,7 +258,7 @@ describe('AuthenticationController', () => {
             });
             keycloakUserServiceMock.getLastPasswordChange.mockResolvedValueOnce({
                 ok: true,
-                value: person.updatedAt.valueOf(),
+                value: person.updatedAt,
             });
             const result: UserinfoResponse = await authController.info(permissions);
 

diff --git a/src/modules/authentication/api/userinfo.response.spec.ts b/src/modules/authentication/api/userinfo.response.spec.ts
@@ -28,7 +28,7 @@ describe('UserinfoResponse', () => {
     });
 
     it('constructs the object with optional extension', () => {
-        const extension: UserinfoExtension = { password_updated_at: faker.date.past().valueOf() };
+        const extension: UserinfoExtension = { password_updated_at: faker.date.past() };
         const userinfoResponse: UserinfoResponse = new UserinfoResponse(permissions, [pk], extension);
         expect(userinfoResponse).toBeDefined();
         expect(userinfoResponse.password_updated_at).toEqual(extension.password_updated_at);

diff --git a/src/modules/keycloak-administration/domain/keycloak-user.service.spec.ts b/src/modules/keycloak-administration/domain/keycloak-user.service.spec.ts
@@ -655,7 +655,7 @@ describe('KeycloakUserService', () => {
             it('should return the timestamp', async () => {
                 kcUsersMock.findOne.mockResolvedValueOnce(mockUser);
                 kcUsersMock.getCredentials.mockResolvedValueOnce(mockCredentials);
-                const result: Result<number, DomainError> = await service.getLastPasswordChange(mockUser.id!);
+                const result: Result<Date, DomainError> = await service.getLastPasswordChange(mockUser.id!);
                 expect(result).toStrictEqual({
                     ok: true,
                     value: updatedAt,
@@ -666,7 +666,7 @@ describe('KeycloakUserService', () => {
             it('should return an error', async () => {
                 kcUsersMock.findOne.mockResolvedValueOnce(mockUser);
                 kcUsersMock.getCredentials.mockRejectedValueOnce({});
-                const result: Result<number, DomainError> = await service.getLastPasswordChange(mockUser.id!);
+                const result: Result<Date, DomainError> = await service.getLastPasswordChange(mockUser.id!);
                 expect(result).toStrictEqual({
                     ok: false,
                     error: new KeycloakClientError('Keycloak request failed'),
@@ -683,7 +683,7 @@ describe('KeycloakUserService', () => {
                 ];
                 kcUsersMock.findOne.mockResolvedValueOnce(mockUser);
                 kcUsersMock.getCredentials.mockResolvedValueOnce(mockCredentials);
-                const result: Result<number, DomainError> = await service.getLastPasswordChange(mockUser.id!);
+                const result: Result<Date, DomainError> = await service.getLastPasswordChange(mockUser.id!);
                 expect(result).toStrictEqual({
                     ok: false,
                     error: new KeycloakClientError('Keycloak user password has never been updated'),
@@ -699,7 +699,7 @@ describe('KeycloakUserService', () => {
             it('should return an error', async () => {
                 kcUsersMock.findOne.mockRejectedValueOnce(null);
                 kcUsersMock.getCredentials.mockResolvedValueOnce(mockCredentials);
-                const result: Result<number, DomainError> = await service.getLastPasswordChange(mockUser.id!);
+                const result: Result<Date, DomainError> = await service.getLastPasswordChange(mockUser.id!);
                 expect(result).toStrictEqual({
                     ok: false,
                     error: new KeycloakClientError('Keycloak request failed'),
@@ -716,7 +716,7 @@ describe('KeycloakUserService', () => {
             it('should return an error', async () => {
                 kcUsersMock.findOne.mockResolvedValueOnce(brokenUser);
                 kcUsersMock.getCredentials.mockResolvedValueOnce(mockCredentials);
-                const result: Result<number, DomainError> = await service.getLastPasswordChange(mockUser.id!);
+                const result: Result<Date, DomainError> = await service.getLastPasswordChange(mockUser.id!);
                 expect(result).toStrictEqual({
                     ok: false,
                     error: new KeycloakClientError('Keycloak user has no createdTimestamp'),
@@ -742,7 +742,7 @@ describe('KeycloakUserService', () => {
                 async ({ credentials, error }: { credentials: Array<CredentialRepresentation>; error: string }) => {
                     kcUsersMock.findOne.mockResolvedValueOnce(mockUser);
                     kcUsersMock.getCredentials.mockResolvedValueOnce(credentials);
-                    const result: Result<number, DomainError> = await service.getLastPasswordChange(mockUser.id!);
+                    const result: Result<Date, DomainError> = await service.getLastPasswordChange(mockUser.id!);
                     expect(result).toStrictEqual({
                         ok: false,
                         error: new KeycloakClientError(error),
@@ -759,7 +759,7 @@ describe('KeycloakUserService', () => {
                 };
 
                 adminService.getAuthedKcAdminClient.mockResolvedValueOnce(error);
-                const res: Result<number, DomainError> = await service.getLastPasswordChange(faker.string.uuid());
+                const res: Result<Date, DomainError> = await service.getLastPasswordChange(faker.string.uuid());
 
                 expect(res).toBe(error);
             });