adjust i18 for Person-UEM-Password, adjust test cases

dBildungsplattform · Dec 11, 2024 · 26c1d76 · 26c1d76
1 parent e864b06
commit 26c1d76
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/src/modules/person/api/dbiam-person.error.ts b/src/modules/person/api/dbiam-person.error.ts
@@ -10,7 +10,7 @@ export enum PersonErrorI18nTypes {
     PERSONALNUMMER_REQUIRED = 'PERSONALNUMMER_REQUIRED',
     NEWER_VERSION_OF_PERSON_AVAILABLE = 'NEWER_VERSION_OF_PERSON_AVAILABLE',
     PERSONALNUMMER_NICHT_EINDEUTIG = 'PERSONALNUMMER_NICHT_EINDEUTIG',
-    PERSON_PASSWORD_MODIFICATION_ERROR = 'PERSON_PASSWORD_MODIFICATION_ERROR',
+    PERSON_UEM_PASSWORD_MODIFICATION_ERROR = 'PERSON_UEM_PASSWORD_MODIFICATION_ERROR',
 }
 
 export type DbiamPersonErrorProps = DbiamErrorProps & {

diff --git a/src/modules/person/api/person-exception-filter.ts b/src/modules/person/api/person-exception-filter.ts
@@ -68,7 +68,7 @@ export class PersonExceptionFilter implements ExceptionFilter<PersonDomainError>
             PersonUserPasswordModificationError.name,
             new DbiamPersonError({
                 code: 500,
-                i18nKey: PersonErrorI18nTypes.PERSON_PASSWORD_MODIFICATION_ERROR,
+                i18nKey: PersonErrorI18nTypes.PERSON_UEM_PASSWORD_MODIFICATION_ERROR,
             }),
         ],
     ]);

diff --git a/src/modules/person/api/person.controller.spec.ts b/src/modules/person/api/person.controller.spec.ts
@@ -948,6 +948,7 @@ describe('PersonController', () => {
                 true,
             );
             personRepositoryMock.updatePersonMetadata.mockResolvedValue(new MismatchedRevisionError(''));
+
             await expect(
                 personController.updateMetadata(params, bodyWithInvalidRevision, personPermissionsMock),
             ).rejects.toThrow(HttpException);
@@ -1042,6 +1043,10 @@ describe('PersonController', () => {
                     personController.resetUEMPasswordByPersonId(params, personPermissionsMock),
                 ).resolves.not.toThrow();
                 expect(ldapClientServiceMock.changeUserPasswordByPersonId).toHaveBeenCalledTimes(1);
+                expect(ldapClientServiceMock.changeUserPasswordByPersonId).toHaveBeenCalledWith(
+                    person.id,
+                    person.referrer,
+                );
             });
         });
 
@@ -1067,6 +1072,10 @@ describe('PersonController', () => {
                     personController.resetUEMPasswordByPersonId(params, personPermissionsMock),
                 ).rejects.toThrow(PersonUserPasswordModificationError);
                 expect(ldapClientServiceMock.changeUserPasswordByPersonId).toHaveBeenCalledTimes(1);
+                expect(ldapClientServiceMock.changeUserPasswordByPersonId).toHaveBeenCalledWith(
+                    person.id,
+                    person.referrer,
+                );
             });
         });
     });