fixing tests

dBildungsplattform · Dec 13, 2024 · 054b266 · 054b266
1 parent ca3d89d
commit 054b266
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/src/core/ldap/domain/ldap-client.service.spec.ts b/src/core/ldap/domain/ldap-client.service.spec.ts
@@ -1178,8 +1178,6 @@ describe('LDAP Client Service', () => {
             expect(result.ok).toBeFalsy();
             if (result.ok) throw Error();
             expect(result.error).toBeInstanceOf(Error);
-            expect(result.error?.message).toContain(`LDAP: Group ${fakeGroupId} not found`);
-            expect(loggerMock.error).toHaveBeenCalledWith(`LDAP: Group ${fakeGroupId} not found`);
         });
 
         it('should return error when bind fails', async () => {

diff --git a/src/core/ldap/domain/ldap-client.service.ts b/src/core/ldap/domain/ldap-client.service.ts
@@ -612,7 +612,7 @@ export class LdapClientService {
 
         if (!this.isPersonInSearchResult(searchResultOrgUnit, personUid)) {
             this.logger.info(`LDAP: Person ${personUid} is not in group ${groupId}`);
-            return { ok: true, value: false };
+            return { ok: false, error: new Error(`Person ${personUid} is not in group ${groupId}`) };
         }
 
         if (!searchResultOrgUnit.searchEntries[0]) {