Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dbp-1067-optional-rollout-prevention #92

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

maxi418
Copy link
Contributor

@maxi418 maxi418 commented Nov 28, 2024

Description

Adds an optional deployment blocker to the pipeline for branches that have an open pull request. The blocker is implemented via the label prevent_auto_deployment. To stop automatic deployments the label has to be added to the pull request.

Links to Tickets or other PRs

Notes

Approval for review

  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@maxi418 maxi418 added the prevent_auto_deployment Setting this label prevents automatic deployments of the dev pipeline label Nov 28, 2024
@maxi418 maxi418 self-assigned this Nov 28, 2024
@maxi418 maxi418 closed this Nov 28, 2024
@maxi418 maxi418 reopened this Nov 29, 2024
@maxi418 maxi418 closed this Nov 29, 2024
@maxi418 maxi418 reopened this Nov 29, 2024
@maxi418 maxi418 removed the prevent_auto_deployment Setting this label prevents automatic deployments of the dev pipeline label Nov 29, 2024
@maxi418 maxi418 added the prevent_auto_deployment Setting this label prevents automatic deployments of the dev pipeline label Nov 29, 2024
@maxi418 maxi418 removed the prevent_auto_deployment Setting this label prevents automatic deployments of the dev pipeline label Nov 29, 2024
@maxi418 maxi418 closed this Nov 29, 2024
@maxi418 maxi418 reopened this Nov 29, 2024
@maxi418 maxi418 requested a review from a team November 29, 2024 15:15
@maxi418 maxi418 marked this pull request as ready for review November 29, 2024 15:15
echo "merge_clearance=false" >> "$GITHUB_OUTPUT"
fi

- name: test output
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed

PR_LABELS=$(gh pr view ${{ env.PR_NUMBER }} --json labels --jq '.labels | map(.name) | join(",")')
echo "PR_LABELS=$PR_LABELS" >> $GITHUB_ENV

- name: Determine merge clearance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the other prs determine_deployment_clearance is used, not merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants