Replace Shuffle implementation with the one provided by .NET

d4n3436 · Jun 23, 2024 · 561fd99 · 561fd99
1 parent 2258126
commit 561fd99
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 43 deletions.
diff --git a/src/Entities/FergunTranslator.cs b/src/Entities/FergunTranslator.cs
@@ -2,7 +2,6 @@
 using System.Collections.Generic;
 using System.Linq;
 using System.Threading.Tasks;
-using Fergun.Extensions;
 using GTranslate;
 using GTranslate.Results;
 using GTranslate.Translators;
@@ -31,7 +30,7 @@ public FergunTranslator(IEnumerable<ITranslator> translators)
     public string Name => nameof(FergunTranslator);
 
     /// <inheritdoc/>
-    public void Randomize(Random? rng = null) => _translators.Shuffle(rng);
+    public void Randomize(Random? rng = null) => (rng ?? Random.Shared).Shuffle(_translators);
 
     /// <inheritdoc />
     public Task<ITranslationResult> TranslateAsync(string text, string toLanguage, string? fromLanguage = null)

diff --git a/src/Extensions/ListExtensions.cs b/src/Extensions/ListExtensions.cs
diff --git a/tests/Fergun.Tests/Entities/FergunTranslatorTests.cs b/tests/Fergun.Tests/Entities/FergunTranslatorTests.cs
@@ -33,7 +33,7 @@ public void FergunTranslator_Name_Returns_Type_Name()
     [Fact]
     public void FergunTranslator_Randomize_Shuffles_Translators()
     {
-        _fergunTranslator.Randomize(new Random(1));
+        _fergunTranslator.Randomize(new Random(0));
 
         Assert.NotSame(_innerTranslatorMock.Object, _fergunTranslator._translators[0]);
     }

diff --git a/tests/Fergun.Tests/Extensions/ListExtensionsTests.cs b/tests/Fergun.Tests/Extensions/ListExtensionsTests.cs