Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 21 students array #30

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Issue 21 students array #30

wants to merge 4 commits into from

Conversation

shuked
Copy link
Contributor

@shuked shuked commented Sep 19, 2021

related to issue #21

@shuked shuked linked an issue Sep 19, 2021 that may be closed by this pull request
add js file with array of students #21
Open
davidmeirlevy
davidmeirlevy reviewed Sep 22, 2021
View reviewed changes
students-array.js Outdated
@@ -0,0 +1,72 @@
const students = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to export the data.

davidmeirlevy
davidmeirlevy requested changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@davidmeirlevy davidmeirlevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the type of the students is an array, but you deliver students, so the file would be called "students" and not "students-array".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmeirlevy davidmeirlevy davidmeirlevy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add js file with array of students
2 participants
@shuked @davidmeirlevy