Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devcontainer): install poetry via devcontainer feature #337

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

kenibrewer
Copy link
Member

@kenibrewer kenibrewer commented Oct 26, 2023

This change will speed up devcontainer loading and resolve some inconsistencies in how vscode treats python environments in the devcontainer

Closes #334

modified from EmbeddedArtistry

Description

VSCode has apparently introduced changes in the way that python environments are loaded

What is the nature of your change?

  • Bug fix (fixes an issue).

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have deleted all non-relevant text in this pull request template.

This change will speed up devcontainer loading and resolve some inconsistencies in how vscode treats python environments in the devcontainer

Closes cytomining#334
@codecov-commenter
Copy link

Codecov Report

Merging #337 (d5e552b) into main (afe5df3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #337   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files          56       56           
  Lines        3134     3134           
=======================================
  Hits         2990     2990           
  Misses        144      144           
Flag Coverage Δ
unittests 95.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kenibrewer kenibrewer requested a review from d33bs October 26, 2023 18:29
Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! LGTM, with one minor comment up to your opinion.

.devcontainer/devcontainer.json Show resolved Hide resolved
@kenibrewer kenibrewer merged commit 500850b into cytomining:main Oct 27, 2023
10 checks passed
@kenibrewer kenibrewer deleted the fix/devcontainer-poetry branch October 27, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Devcontainer setup shell is missing required programs
3 participants