Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(devcontainer): move vscode settings into devcont config #336

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

kenibrewer
Copy link
Member

@kenibrewer kenibrewer commented Oct 26, 2023

This allows people not using the devcontainer option for development to modify settings without fear of committing changes to repo.

Closes #332

Description

Thank you for your contribution to pycytominer!
Please succinctly summarize your proposed change.
What motivated you to make this change?

Please also link to any relevant issues that your code is associated with.

What is the nature of your change?

  • Refactor (This neither adds a feature nor changes functionality)

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have deleted all non-relevant text in this pull request template.

This allows people not using the devcontainer option for development to modify settings without fear of committing changes to repo

Closes cytomining#332
@kenibrewer kenibrewer requested a review from d33bs October 26, 2023 17:38
Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I thought things LGTM and only had minor comments. Please don't hesitate to let me know if you have any questions.

.devcontainer/devcontainer.json Show resolved Hide resolved
.devcontainer/devcontainer.json Show resolved Hide resolved
@kenibrewer kenibrewer merged commit 893dd53 into cytomining:main Oct 27, 2023
10 checks passed
@kenibrewer kenibrewer deleted the refactor/vscode-settings branch February 20, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RefactorRequest: Move .vscode configuration into devcontainer.json
2 participants