Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: separate yarn and pnpm maintenance scripts #1163

Merged

Conversation

MikeMcC399
Copy link
Collaborator

Issue

The maintenance scripts, which update the Cypress examples, combine pnpm and Yarn actions in one script. As the number of examples has grown to cover different package manager variants for Yarn and pnpm, this has become less flexible to maintain.

Changes

The contents of the scripts

are split into separate scripts for Yarn and pnpm respectively.

The overall function remains the same and the documentation docs/MAINTENANCE.md needs no changes.

Verification

On Ubuntu 22.04.04 LTS with Node.js 20.12.0 LTS, execute:

git clean -xfd
npm ci
npm run update:cypress

and confirm success.

@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 marked this pull request as ready for review April 1, 2024 11:00
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jennifer-shehane jennifer-shehane merged commit 488f829 into cypress-io:master Apr 1, 2024
76 checks passed
@MikeMcC399 MikeMcC399 deleted the refactor/update-scripts branch April 1, 2024 14:06
Copy link

🎉 This PR is included in version 6.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants