Merge pull request #21 from Shadow243/refactoring-redirect-filter-action

Refactor if condition in parse function
cypht-org · Aug 3, 2024 · 3590d0f · 3590d0f
2 parents d013d04 + 4c36022
commit 3590d0f
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/src/Filters/Actions/RedirectFilterAction.php b/src/Filters/Actions/RedirectFilterAction.php
@@ -29,10 +29,8 @@ public function parse() {
             $this->require[] = 'copy';
             $script .= " :copy";
         }
-        if (isset($this->params['notify']) || isset($this->params['notify'])) {
-            $this->require[] = 'redirect-dsn';
-        }
         if (!empty($this->params['notify'])) {
+            $this->require[] = 'redirect-dsn';
             $script .= " :notify \"{$this->params['notify']}\"";
         }
         if (!empty($this->params['ret'])) {