Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(other): gmail messages not shown #1409

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

christer77
Copy link
Member

see issue

ref: RFC

@christer77 christer77 requested a review from kroky December 20, 2024 14:27
@indridieinarsson
Copy link
Contributor

May I add a comment?
The issue ( #1402 ) turns out to be really two different things. One is the inability of gmail to process BODY.PEEK[0.1] (but I think BODY[0.1] is fine, so might consider changing that one back). And I think this PR fixes that (but I'm not quite sure what info we might be missing by changing from [0.1] to [1]? )

The other thing is that in the combined view, the automatic check and renewal of the xoauth2 bearer token (which is valid for 1 hour after renewal) does not take place, and this PR doesn't fix that.

I made some code that seems to fix this part of it : indridieinarsson@3c74c2a
For the dedicated mailbox pages, the old code checks which mail server it is serving, and checks that server for expiry. But the request for the combined view yields and empty list of servers so no check is performed. In this case, I just check expiry for all available servers. A bit course, but maybe harmless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants