feat(other): add All Snoozed button and Icon to left menu #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DKing2222
force-pushed
the
add-snoozed-folder-and-icon
branch
2 times, most recently
from
d9f9e94 to
2795955
Compare
|
Can you fix the unit tests? |
DKing2222
force-pushed
the
add-snoozed-folder-and-icon
branch
from
2795955 to
173aef0
Compare
DKing2222
changed the title
DKing2222
changed the title
DKing2222
force-pushed
the
add-snoozed-folder-and-icon
branch
from
173aef0 to
cf56143
Compare
DKing2222
changed the title
I've fixed the unit tests, resolved the conflicts, and pushed the changes. |
kroky
reviewed
Dec 17, 2024
modules/imap/functions.php
Outdated
| @@ -34,6 +34,9 @@ function imap_sources($mod, $folder = 'sent') { | |||
| elseif ($inbox) { | |||
| $sources[] = array('folder' => bin2hex('INBOX'), 'type' => 'imap', 'name' => $vals['name'], 'id' => $index); | |||
| } | |||
| elseif ($folder=="snoozed"){ | |||
| $sources[] = array('callback' => $callback, 'folder' => bin2hex('Snoozed'), 'type' => 'imap', 'name' => $vals['name'], 'id' => $index); | |||
There was a problem hiding this comment.
Master doesn't use callback anymore, it seems.
Also, I just merged the EWS stuff, please rebase against latest master and resolve any conflicts. There should be a folder_name here after you rebase.
There was a problem hiding this comment.
Thanks for the update, @kroky !
I'll rebase against the latest master, resolve the conflicts, and look into the folder_name issue.
I'll get back to you shortly.
DKing2222
force-pushed
the
add-snoozed-folder-and-icon
branch
from
cf56143 to
5a1cd41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
#1302