Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(other): nightly-image #1325

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SKB-TECH
Copy link

@SKB-TECH SKB-TECH commented Nov 6, 2024

correction of the Neghtly-Image file to push code every midnight

Relare discussion: #1175
Related internal tracker item: https://avan.tech/item113468

@josaphatim josaphatim changed the title [Fix]Neghtly-Image [Fix] Nightly-Image Nov 6, 2024
@josaphatim
Copy link
Member

Also I wonder why pipelines didn't run

@Shadow243
Copy link
Member

Updating .github/workflows/Nightly-Image.yml like that no job will run. you can check at https://github.com/cypht-org/cypht/pull/1325/checks

@SKB-TECH SKB-TECH force-pushed the Fix-Neghtly_Image branch 4 times, most recently from d65f245 to b695b85 Compare November 7, 2024 10:54
@Shadow243 Shadow243 force-pushed the Fix-Neghtly_Image branch 4 times, most recently from f92c223 to b695b85 Compare November 10, 2024 08:04
@marclaporte
Copy link
Member

Some context on what was discussed: #1175

@SKB-TECH SKB-TECH changed the title [Fix] Nightly-Image feature(other): nightly-image Dec 2, 2024
@SKB-TECH SKB-TECH changed the title feature(other): nightly-image feat(other): nightly-image Dec 2, 2024
@SKB-TECH SKB-TECH force-pushed the Fix-Neghtly_Image branch 5 times, most recently from c464bdb to 0557469 Compare December 3, 2024 00:14
@marclaporte
Copy link
Member

Unless someone has a preference for nightly, please switch everything to use "daily"
#1175 (comment)
We want to do this before people start using.

Please also make sure to take into account all the discussions at:
#1175
If you disagree with some suggestions, or there are contradictions and you don't know what to do, please indicate in the issue so we get the wisdom of people involved.

defaults:
run:
shell: bash
name: Build Daily Image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file name Nightly-Image.yml should be renamed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants