Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(other): screen email: fix adding to trust contact while the email is blo… #1265

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

christer77
Copy link
Member

This PR resolves issue's points 4 and 5

@christer77 christer77 force-pushed the fix-Adding-to-Trust-Contact-while-the-email-adress-is-blocked branch from 4e5f6c9 to ab14f8d Compare October 3, 2024 11:05
@christer77 christer77 marked this pull request as ready for review October 3, 2024 11:06
@marclaporte marclaporte requested a review from Shadow243 October 4, 2024 03:04
@Shadow243
Copy link
Member

@christer77 please rebase to fix failing tests.

@christer77 christer77 force-pushed the fix-Adding-to-Trust-Contact-while-the-email-adress-is-blocked branch 2 times, most recently from 543849a to 8b8ffb6 Compare October 9, 2024 07:14
modules/imap/site.js Outdated Show resolved Hide resolved
@christer77 christer77 force-pushed the fix-Adding-to-Trust-Contact-while-the-email-adress-is-blocked branch from 8b8ffb6 to 3b3122a Compare October 10, 2024 06:23
@christer77 christer77 force-pushed the fix-Adding-to-Trust-Contact-while-the-email-adress-is-blocked branch from 3b3122a to 2a6f525 Compare October 21, 2024 11:45
@Baraka24 Baraka24 requested a review from Shadow243 October 25, 2024 22:59
@christer77 christer77 requested review from Shadow243 and removed request for Shadow243 November 6, 2024 11:30
@christer77 christer77 force-pushed the fix-Adding-to-Trust-Contact-while-the-email-adress-is-blocked branch from 2a6f525 to 8afda19 Compare November 6, 2024 11:42
modules/imap/site.js Outdated Show resolved Hide resolved
@christer77 christer77 force-pushed the fix-Adding-to-Trust-Contact-while-the-email-adress-is-blocked branch from 8afda19 to c31c7d6 Compare November 6, 2024 11:52
Copy link
Member

@Shadow243 Shadow243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some updates to be done.

modules/imap/site.js Outdated Show resolved Hide resolved
modules/sievefilters/modules.php Show resolved Hide resolved
@christer77 christer77 force-pushed the fix-Adding-to-Trust-Contact-while-the-email-adress-is-blocked branch 2 times, most recently from 88ef6b3 to ff8bf62 Compare November 13, 2024 12:44
@christer77 christer77 requested a review from Shadow243 November 15, 2024 14:52
modules/imap/site.js Outdated Show resolved Hide resolved
@christer77 christer77 changed the title [FIX]Screen email: fix Adding to Trust Contact while the email is blo… fix(cypht):screen email: fix adding to trust contact while the email is blo… Nov 28, 2024
@christer77 christer77 changed the title fix(cypht):screen email: fix adding to trust contact while the email is blo… fix(cypht): screen email: fix adding to trust contact while the email is blo… Nov 28, 2024
@christer77 christer77 force-pushed the fix-Adding-to-Trust-Contact-while-the-email-adress-is-blocked branch from ff8bf62 to 6e9ef23 Compare November 28, 2024 07:23
@christer77 christer77 force-pushed the fix-Adding-to-Trust-Contact-while-the-email-adress-is-blocked branch from 6e9ef23 to 6109e25 Compare November 30, 2024 10:28
@christer77 christer77 changed the title fix(cypht): screen email: fix adding to trust contact while the email is blo… fix: screen email: fix adding to trust contact while the email is blo… Nov 30, 2024
@christer77 christer77 changed the title fix: screen email: fix adding to trust contact while the email is blo… fix(other): screen email: fix adding to trust contact while the email is blo… Nov 30, 2024
modules/imap/site.js Outdated Show resolved Hide resolved
@christer77 christer77 force-pushed the fix-Adding-to-Trust-Contact-while-the-email-adress-is-blocked branch from 6109e25 to bc9657f Compare December 19, 2024 15:19
@christer77 christer77 force-pushed the fix-Adding-to-Trust-Contact-while-the-email-adress-is-blocked branch from bc9657f to d1d728c Compare December 20, 2024 14:29
@Shadow243 Shadow243 requested a review from kroky December 20, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Blocking and Adding Behavior for Email Address in Contacts List
3 participants