Update enumify to 2.x #448
Conversation
…s (static fields in enum class declaration)
|
This was a small change that was complicated by a series of factors. First, the library was updated to TypeScript, and using static fields in classes, which needs a Babel plug-in to work (rauschma/enumify#21). However, adding that plug-in broke the instrumentation we have in place for tests. That's because Istanbul was configured to run before Babel. So the Babel plug-ins had no effect (webpack-contrib/istanbul-instrumenter-loader#89). Fixing the first problem was easy, just a matter of installing and loading the plug-in. The second one took me longer than expected, but also taught me more about Babel, Istanbul, and our current setup with Vue 2. In order to fix the second problem, of Istanbul not taking into consideration Babel plug-ins, first I found that the latest releases (3.x and 4.) of So I remembered reading about resolutions in the Yarn docs. This is similar to how transitive dependencies can be overridden in Maven. We basically tell Yarn to ignore the dependency used by the library, and instead trust us and use the version we give it. Once that's done, everything works. This same procedure would have to be done if we ever needed to use other Babel plug-ins, so I think it should be OK to add it now. |
| @@ -1,5 +1,8 @@ | |||
| module.exports = { | |||
| presets: [ | |||
| '@vue/app' | |||
| ], | |||
| plugins: [ | |||
| ['@babel/plugin-proposal-class-properties', { loose: true }] | |||
There was a problem hiding this comment.
So that we support static fields in classes with ES6. (loose so that it is less strict with how we define the static fields)
| @@ -7,7 +7,7 @@ | |||
| "build": "vue-cli-service build", | |||
| "build:report": "vue-cli-service build --report", | |||
| "build:watch": "vue-cli-service build --watch --mode development", | |||
| "checkpoint" : "./src/services/mock/generate", | |||
| "checkpoint": "./src/services/mock/generate", | |||
| @@ -89,6 +90,9 @@ | |||
| "vuetify-loader": "^1.3.0", | |||
| "webpack": "^4.41.0" | |||
| }, | |||
| "resolutions": { | |||
| "istanbul-instrumenter-loader/**/istanbul-lib-instrument": "4.0.1" | |||
| }, | |||
There was a problem hiding this comment.
Overriding the dependency of the loader, as the new Istanbul instrument library loads Babel plug-ins. Alas it seems like a release with the new version might take a while over there.
|
😭 |
Did you get that running |
| class TaskState extends Enumify { | ||
| // NOTE: the order of the enum values is important to calculate the group states in the UI. Items at | ||
| // the top of the list have preference over the items below in the algorithm. | ||
| static SUBMIT_FAILED = new TaskState('SUBMIT_FAILED') |
There was a problem hiding this comment.
class TaskState has attribute which are TaskState instances, very meta!
This is a small change with no associated Issue.
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.