Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite DbTypes table #385

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Rewrite DbTypes table #385

merged 1 commit into from
Sep 13, 2024

Conversation

bennibbelink
Copy link
Contributor

@bennibbelink bennibbelink commented Sep 13, 2024

Closes #384.

I wasn't able to get the old version to render correctly so I'm not 100% sure what it was supposed to look like, but I think this working version looks alright. It may(?) have been a pivot table previously, and if we want that functionality back it wouldn't be hard to implement (https://pivottable.js.org/examples/), but for now it is just a pretty basic table (with search/sort functionality).

Have a look and let me know what you think.

@bennibbelink bennibbelink requested a review from gonuke September 13, 2024 00:50
@gonuke
Copy link
Member

gonuke commented Sep 13, 2024

I don't see it in the artifact from testing... do I need to build locally to see it?

@bennibbelink
Copy link
Contributor Author

Are you sure you're serving the correct build artifact? This is what I see from the artifact in this workflow run https://github.com/cyclus/cyclus.github.com/actions/runs/10840934866?pr=385

Screenshot 2024-09-12 at 9 06 10 PM

@gonuke
Copy link
Member

gonuke commented Sep 13, 2024

Strange... I get this....
Screenshot 2024-09-12 at 20 16 46

but when I look at the source, I see all the right source there to render the table...??

@gonuke
Copy link
Member

gonuke commented Sep 13, 2024

Oh... it looks like you're serving it on localhost - I'm just loading the file...

@gonuke
Copy link
Member

gonuke commented Sep 13, 2024

found a quick server: python3 -m http.server and it worked!

@bennibbelink
Copy link
Contributor Author

Oh... it looks like you're serving it on localhost - I'm just loading the file...

Yep I always preview it using python3 -m http.server

Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bennibbelink - I don't think we were actually using the pivot table capabilities and this has the capabilities that matter

@gonuke gonuke merged commit 9958e61 into cyclus:source Sep 13, 2024
2 checks passed
@bennibbelink bennibbelink deleted the dbtypes-table branch September 13, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Database Types table needs fixing
2 participants