Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for new constants #381

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Conversation

bennibbelink
Copy link
Contributor

Closes #380.

I also modified the dockerfile to no longer mamba update -y --all because it was updating libraries that cyclus depends on (specifically libicudata.so could not be found), rendering cyclus unusable. I'm not sure if we will run into trouble later on of mamba not being able to find the sphinx packages required for building the site. I think that the update command might be a remnant of using an apt build (needing to update package indexes in order to find the sphinx packages), and I'm not sure that it's necessary with conda/mamba.

@bennibbelink bennibbelink requested a review from gonuke August 3, 2024 21:55
@bennibbelink
Copy link
Contributor Author

@gonuke feel free to tag some active archetype developers. I would love to hear their feedback on the docs as well but am not sure who all to bother 😄 nuclearkatie? abachma2?

@nuclearkatie
Copy link
Contributor

Sorry if this is a basic question but I haven't been following this saga closely. Are the new variables able to be used in prototype declarations in input files, or only in core cyclus and archetype code bases? Like, can you declare a source with

<facility>
  <name>ExSource</name>
  <config>
    <Source
      <outcommod>commod</outcommod>
      <inventory_size>CY_LARGE_DOUBLE</inventory_size>
    </Source>
  </config
</facility>

in an input file and have it process correctly? I think either way, the docs should be clear about whether you can do this

@bennibbelink
Copy link
Contributor Author

@nuclearkatie good question. They can be used in input files written in Python, but not XML. The latest commit clarifies this in the docs

Copy link
Member

@katyhuff katyhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. I suspect the mamba issue you've fixed here might solve some installation issues one of our ARFC undergrads may be experiencing. I have no recommended edits.

@bennibbelink
Copy link
Contributor Author

If there are no further requests for changes, can someone merge this please?

@gonuke gonuke merged commit 3461fd8 into cyclus:source Sep 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add instructions for using constants in archetype development
4 participants