More general updates #367

abachma2 · 2024-04-29T21:56:49Z

This PR addresses some of the issues raised in #337, specifically:

some of the build warnings from source/cep/cep27.rst
adding a news item
adding a missing version release for v1.5.5.
fixing typos/small issues identified by @dean-krueger
removing the data_explorer.rst from the user tutorial
removing mention of cloud for running cyclus from user tutorial.

The data_explorer page was missing figures, and used an `analysi` package that is not available through Cyclus. Use of this page was replaced with pointing to the Cymetric github for analysis and examples

bennibbelink · 2024-05-04T18:08:44Z

source/previous/v1.5.5.rst

@@ -0,0 +1,57 @@
+.. _1.5.5:
+


In our meeting on Monday we discussed modifying the "Cyclus Previous Versions" page to simply reference the GitHub releases. The releases already have the changes in the descriptions so it probably isn't necessary to copy/paste that information into the site as well. Do you have any thoughts about this?

So something like pointing to this page for the 1.5.5 release? Instead of having separate web pages for the releases?

Not sure if we even need to link each release... we could say that all the releases can be found at this page so we don't need to manually copy/paste info from Github to the site with each release. I might have misunderstood the group consensus though - @gonuke what did you have in mind?

EDIT: Thats exactly what you did sorry :) I should've looked closer at your changes before commenting

bennibbelink · 2024-05-06T22:06:40Z

Not sure if you saw my PR to your branch. This small change could be thrown into this PR.

bennibbelink · 2024-05-06T22:12:32Z

source/previous/index.rst

+Release notes and changelogs for previous versions of |Cyclus| are 
+available through the `project GitHub <https://github.com/cyclus/cyclus/releases>`_.
+These pages also contain zips for the source code of each version. These zip 
+packages are also available below. 


Do we need to maintain this table of zips/tarballs still?

While I agree that it would be great to avoid maintaining the table, it's nice to get a compact view of releases/release dates.... wonder if can automate that in a future update (i.e. make an issue)

All of the zips are on the github tags page. Maybe link to those?

bennibbelink · 2024-05-06T22:15:17Z

source/news/fy24neup.rst

+
+.. _NEUP: http://www.neup.gov
+
+.. _MARKAL: http://www.iea-etsap.org/web/Markal.asp


Suggested change

.. _MARKAL: http://www.iea-etsap.org/web/Markal.asp

bennibbelink · 2024-05-06T22:16:08Z

source/news/fy24neup.rst

+
+.. _MARKAL: http://www.iea-etsap.org/web/Markal.asp
+
+.. _GCAM: http://www.globalchange.umd.edu/models/gcam/


Suggested change

.. _GCAM: http://www.globalchange.umd.edu/models/gcam/

bennibbelink · 2024-05-06T22:24:04Z

source/user/tutorial/index.rst

@@ -30,7 +30,6 @@ Exercise #1
    add_commod_recipe
    add_proto
    add_reg_inst
-    launch_cyclus


I see this removes "Using Cyclus in the Cloud". There is another reference to the cloud service in user/tutorial/install_launch_cyclus that should probably also be removed.

I'll make sure that gets removed. This cloud service isn't working, so we shouldn't get users' hopes up that they don't have to install locally.

gonuke

Not sure why we're deleting the data explorer page?

gonuke · 2024-05-07T01:21:27Z

source/user/tutorial/data_explorer.rst

Why are we getting rid of this?

It's not actually called anywhere, like no other page links to it

It uses a python package (analaysis.py) that I don't know where people are supposed to get access to it.

We link to the Cymetric GitHub in one of the pages for how to use that tool for analysis

We are missing a bunch of figures that are supposed to go on this page, and I think it would be nontrivial to recreate them, especially since I don't have the analysis.py to replicate the procedure.

Thanks, I it didn't appear to be so immediately out of date on my scan during review, but that all makes sense.

Fair question. And I think I included some of this information in the commit message when I deleted it, so hopefully it helps to answer future questions.

Update version number in sidebar

abachma2 · 2024-05-07T13:41:18Z

One note about removing the release notes from the website: Some of the Release notes with the tags on GitHub point to those pages (like v1.3). Should we just copy the contents of the web pages to these notes? To make sure we don't lose anything and it's all in the same place?

gonuke · 2024-05-08T15:57:59Z

One note about removing the release notes from the website: Some of the Release notes with the tags on GitHub point to those pages (like v1.3). Should we just copy the contents of the web pages to these notes? To make sure we don't lose anything and it's all in the same place?

It looks like v1.3 may have been the only one and I just copy/pasted the content to the release info on each of Cyclus/Cycamore/Cymetric

abachma2 added 5 commits April 29, 2024 16:04

address issues from @dean-krueger

d522328

add news item for Fy24 funding

ce46d74

remove data_explorer from tutorial

812a5b8

The data_explorer page was missing figures, and used an `analysi` package that is not available through Cyclus. Use of this page was replaced with pointing to the Cymetric github for analysis and examples

add v1.5.5 notes -- to be filled in

8411de1

change formatting to remove build warnings

57326f9

bennibbelink reviewed May 4, 2024

View reviewed changes

bennibbelink and others added 3 commits May 5, 2024 09:02

update version number in sidebar

376e6f8

add Ken to PI list

63b2c3e

change release notes to point to github notes

18dbb43

abachma2 marked this pull request as ready for review May 6, 2024 21:27

abachma2 requested review from bennibbelink, gonuke, munkm, nuclearkatie, nsryan2 and dean-krueger May 6, 2024 21:27

abachma2 self-assigned this May 6, 2024

abachma2 added the 1 - Ready label May 6, 2024

bennibbelink requested changes May 6, 2024

View reviewed changes

gonuke requested changes May 7, 2024

View reviewed changes

abachma2 added 2 commits May 7, 2024 08:17

Merge pull request #1 from bennibbelink/sidebar-version

47c2cd0

Update version number in sidebar

add item for v1.6 release, change other releases to GitHub release notes

0260fb9

abachma2 requested review from gonuke and bennibbelink May 7, 2024 13:41

abachma2 added 3 commits May 7, 2024 08:42

remove unused links

21e2ce0

improve news date consistency

401e58c

remvoe mention of cloud service

e8bf0fa

gonuke approved these changes May 8, 2024

View reviewed changes

bennibbelink approved these changes May 8, 2024

View reviewed changes

bennibbelink merged commit a33ddfd into cyclus:source May 8, 2024
2 checks passed

bennibbelink mentioned this pull request Aug 9, 2024

Cloudlus retired #322

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More general updates #367

More general updates #367

abachma2 commented Apr 29, 2024

bennibbelink May 4, 2024

abachma2 May 6, 2024

bennibbelink May 6, 2024 •

edited

Loading

bennibbelink commented May 6, 2024

bennibbelink May 6, 2024

gonuke May 7, 2024

abachma2 May 7, 2024

bennibbelink May 6, 2024

bennibbelink May 6, 2024

bennibbelink May 6, 2024

abachma2 May 7, 2024

gonuke left a comment

gonuke May 7, 2024

abachma2 May 7, 2024

gonuke May 7, 2024

abachma2 May 7, 2024

abachma2 commented May 7, 2024 •

edited

Loading

gonuke commented May 8, 2024


		.. _NEUP: http://www.neup.gov

		.. _MARKAL: http://www.iea-etsap.org/web/Markal.asp


		.. _MARKAL: http://www.iea-etsap.org/web/Markal.asp

		.. _GCAM: http://www.globalchange.umd.edu/models/gcam/

More general updates #367

More general updates #367

Conversation

abachma2 commented Apr 29, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bennibbelink May 6, 2024 • edited Loading

Choose a reason for hiding this comment

bennibbelink commented May 6, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gonuke left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abachma2 commented May 7, 2024 • edited Loading

gonuke commented May 8, 2024

bennibbelink May 6, 2024 •

edited

Loading

abachma2 commented May 7, 2024 •

edited

Loading