-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Makefile and README to reflect new publishing procedure #358
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me @bennibbelink - thanks. I'll request @abachma2 review this as well, since she's been active in website development.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the website builds upon merging to the source
branch, so we don't have to maintain a main
branch. Are these the only places where we need to update the documentation? Did you grep
for where ever the commands and the main branch are mentioned? If this is all that needs to up updated for documentation then this looks good to me.
Just went through and made a couple more small changes to remove references to the main branch. I think now I got them all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bennibbelink Thanks for going through some more of the build. I have a few questions about spots that we may or may not need anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Thanks for making those changes @bennibbelink
Closes #357. We now publish via GitHub Actions so this PR documents this in the README. It also removes targets from the Makefile that were intended for publishing the site.
The new minimum version numbers are the versions used by CI (our
cymetric:latest
image). The actual minimum version numbers are likely lower than is listed.