Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Boost 1.86 #637

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Support Boost 1.86 #637

merged 2 commits into from
Nov 7, 2024

Conversation

bennibbelink
Copy link
Contributor

Adds a -DBOOST_VERSION_MINOR definition to support changes in cyclus/cyclus#1792.

@bennibbelink bennibbelink mentioned this pull request Nov 7, 2024
Merged
@bennibbelink bennibbelink marked this pull request as ready for review November 7, 2024 13:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024 •
edited
Loading

Build Status Report - 7381267 - 2024-11-07 08:39:21 -0500

Build FROM cyclus_20.04_apt/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_20.04_apt/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_20.04_conda/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_20.04_conda/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_apt/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_22.04_apt/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_conda/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_22.04_conda/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_24.04_apt/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_24.04_apt/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_24.04_conda/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_24.04_conda/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️

gonuke
gonuke approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this now as it's simple, non-threatening and will help other debugging

@gonuke gonuke merged commit e4ff5c4 into cyclus:main Nov 7, 2024
14 checks passed
@bennibbelink bennibbelink deleted the boost-1.86 branch November 7, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gonuke gonuke gonuke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bennibbelink @gonuke