Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source prevent seg fault due to packaging failure #629

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Source prevent seg fault due to packaging failure #629

merged 1 commit into from
Sep 24, 2024

Conversation

nuclearkatie
Copy link
Contributor

Closes #628

@github-actions GitHub Actions
Copy link

Build Status Report - a74aa8a - 2024-09-23 14:14:44 -0600

Build FROM cyclus_20.04_apt/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_20.04_apt/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_20.04_conda/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_20.04_conda/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_apt/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_22.04_apt/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_conda/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_22.04_conda/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️

@nuclearkatie nuclearkatie requested a review from gonuke September 23, 2024 20:19
@nuclearkatie nuclearkatie self-assigned this Sep 23, 2024
@nuclearkatie nuclearkatie marked this pull request as ready for review September 23, 2024 20:19
gonuke
gonuke approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @nuclearkatie

@gonuke gonuke merged commit 6dc5ecb into cyclus:main Sep 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gonuke gonuke gonuke approved these changes

Assignees

@nuclearkatie nuclearkatie

Labels
Defect
Projects
None yet
Milestone
Bulk-to-Discrete packaging
Development

Successfully merging this pull request may close these issues.

In source, package-related "failed" trades cause seg faults
2 participants
@nuclearkatie @gonuke