-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prettify Cycamore docs #626
Conversation
Build Status Report - 390f3bc - 2024-09-21 10:02:24 -0400Build
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just one question about reusing the stylesheet from cyclus
doc/doxygen-awesome.css
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get this from cyclus rather than including it again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could modify the cyclus build to install the stylesheet somewhere in ${INSTALL_DIR}/share/cyclus
(perhaps we add a doc/
subdirectory). I'm not sure how else to get it from cyclus, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to do the same with the logo?
I'm happy to merge this now and wait for style sheet cross-repo fixes... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bennibbelink
Something odd is happening... the new style changes (for cyclus) are present in the artifact generated by cyclus.github.com actions but I'm not seeing them in the published site. The docs were present before adding them back into the build so I'm wondering if there's another server somewhere? |
Aha! The cyclus repo has Pages set up to serve the docs. Is it okay if I turn this (and the cycamore one) off? That way the docs will be accessible from just the cyclus.github.com site |
Just to make sure I understand... it seems that And that is blocking the ability to simply serve docs from the website file structure.... I think it's probably OK to turn of pages since the same URL will serve the new information and we never had a mechanism to automate the update of the The other alternative would be something that guarantees that the |
Yes, this is my understanding.
That is also an option. It would require that we maintain actions in cylus and cycamore to do this. I think I would lean toward managing all of the site content in one place (cyclus.github.com's Dockerfile) for the sake of transparency. Having subpaths of a website served from separate repositories doesn't feel very intuitive, and is part of the reason it took me so long to understand where those docs were being produced. |
Also I went ahead and changed this to find the stylesheet/gif at the location installed by cyclus. |
Makes essentially the same changes as cyclus/cyclus#1787
zip for preview
html.zip