Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding transport units to Storage #616

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Conversation

nuclearkatie
Copy link
Contributor

Adds a new parameter to Storage to take advantage of the transport unit capability in the material sell policy.

Closes #557

Copy link

github-actions bot commented Jul 18, 2024

Build Status Report - 5e4f9e0 - 2024-07-19 16:07:49 +0000

Build FROM cyclus_20.04_apt/cyclus:latest
  • Cycamore: Success
  • Cymetric: Success
Build FROM cyclus_20.04_apt/cyclus:stable
  • Cycamore: Failure
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_20.04_conda/cyclus:latest
  • Cycamore: Success
  • Cymetric: Success
Build FROM cyclus_20.04_conda/cyclus:stable
  • Cycamore: Failure
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_apt/cyclus:latest
  • Cycamore: Success
  • Cymetric: Success
Build FROM cyclus_22.04_apt/cyclus:stable
  • Cycamore: Failure
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_conda/cyclus:latest
  • Cycamore: Success
  • Cymetric: Success
Build FROM cyclus_22.04_conda/cyclus:stable
  • Cycamore: Failure
  • Cymetric: Skipped due to upstream failure ⚠️

Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks straightforward and correct to me. Not sure why it's failing tests on cyclus:latest though, but I'm still a little confused on what's what.

@gonuke
Copy link
Member

gonuke commented Jul 19, 2024

Ah - maybe just needed a rebase? Looks good now. Ready to merge if you are - convert from draft.

@nuclearkatie nuclearkatie marked this pull request as ready for review July 19, 2024 16:35
@nuclearkatie
Copy link
Contributor Author

Yep! Needed a rebase and a changelog entry

@gonuke gonuke merged commit c883f9a into cyclus:main Jul 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demonstrate multiple discrete packaging in at least one archetype
2 participants