Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link against libxml++ imported target #608

Merged
merged 2 commits into from
May 21, 2024

Conversation

bennibbelink
Copy link
Contributor

@bennibbelink bennibbelink commented May 21, 2024

This change was implemented in cyclus already in cyclus/cyclus#1748. It resolves issues with linking in a conda-forge feedstock, and issues with linking on MacOS.

Copy link

github-actions bot commented May 21, 2024

Build Status Report - 99798e8 - 2024-05-21 19:06:19 +0000

Build FROM cyclus_20.04_apt/cyclus:latest
  • Cycamore: Success
  • Cymetric: Success
Build FROM cyclus_20.04_apt/cyclus:stable
  • Cycamore: Success
  • Cymetric: Success
Build FROM cyclus_20.04_conda/cyclus:latest
  • Cycamore: Success
  • Cymetric: Success
Build FROM cyclus_20.04_conda/cyclus:stable
  • Cycamore: Success
  • Cymetric: Success
Build FROM cyclus_22.04_apt/cyclus:latest
  • Cycamore: Success
  • Cymetric: Success
Build FROM cyclus_22.04_apt/cyclus:stable
  • Cycamore: Success
  • Cymetric: Success
Build FROM cyclus_22.04_conda/cyclus:latest
  • Cycamore: Success
  • Cymetric: Success
Build FROM cyclus_22.04_conda/cyclus:stable
  • Cycamore: Success
  • Cymetric: Success

@bennibbelink bennibbelink marked this pull request as ready for review May 21, 2024 19:17
@bennibbelink bennibbelink requested a review from gonuke May 21, 2024 19:17
@gonuke gonuke merged commit d86a703 into cyclus:main May 21, 2024
10 checks passed
@bennibbelink bennibbelink deleted the libxml-targets branch May 21, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants