Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add packaging to storage #603

Merged
merged 6 commits into from
Jun 7, 2024
Merged

Add packaging to storage #603

merged 6 commits into from
Jun 7, 2024

Conversation

nuclearkatie
Copy link
Contributor

@nuclearkatie nuclearkatie commented May 14, 2024 •
edited
Loading

Must come after cyclus PR#1749

Closes #552

@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited
Loading

Build Status Report - 0d2c74c - 2024-06-03 08:52:44 -0600

Build FROM cyclus_20.04_apt/cyclus:latest
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_20.04_apt/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_20.04_conda/cyclus:latest
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_20.04_conda/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_apt/cyclus:latest
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_apt/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_conda/cyclus:latest
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_conda/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️

@nuclearkatie nuclearkatie mentioned this pull request May 22, 2024
Merged
@nuclearkatie nuclearkatie marked this pull request as ready for review May 23, 2024 18:06
gonuke
gonuke requested changes May 30, 2024
View reviewed changes
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a little more description in the tests to know what's happening here.

src/storage_tests.cc Outdated Show resolved Hide resolved
src/storage_tests.cc Show resolved Hide resolved
@gonuke
Copy link
Member

gonuke commented May 31, 2024

This needs a rebase b/c conflicts in CHANGELOG

@nuclearkatie
Copy link
Contributor Author

rebased

gonuke
gonuke approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extra comments @nuclearkatie

@gonuke gonuke merged commit 718bcd7 into cyclus:main Jun 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gonuke gonuke gonuke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Demonstrate packaging of bulk to discrete items in at least one archetype
2 participants
@nuclearkatie @gonuke