Fix link in DEPENDENCIES.rst

[bennibbelink]

Closes #594. Needed to add a space between the link text and the brackets. Renders correctly on my local site build.

[github-actions]

Build Status Report - 796f798 - 2024-04-29 14:34:54 -0500

Build FROM cyclus_20.04_apt/cyclus:latest

• Cycamore: Failure ❌
• Cymetric: Skipped due to upstream failure ⚠️

Build FROM cyclus_20.04_apt/cyclus:stable

• Cycamore: Failure ❌
• Cymetric: Skipped due to upstream failure ⚠️

Build FROM cyclus_20.04_conda/cyclus:latest

• Cycamore: Failure ❌
• Cymetric: Skipped due to upstream failure ⚠️

Build FROM cyclus_20.04_conda/cyclus:stable

• Cycamore: Failure ❌
• Cymetric: Skipped due to upstream failure ⚠️

Build FROM cyclus_22.04_apt/cyclus:latest

• Cycamore: Failure ❌
• Cymetric: Skipped due to upstream failure ⚠️

Build FROM cyclus_22.04_apt/cyclus:stable

• Cycamore: Failure ❌
• Cymetric: Skipped due to upstream failure ⚠️

Build FROM cyclus_22.04_conda/cyclus:latest

• Cycamore: Failure ❌
• Cymetric: Skipped due to upstream failure ⚠️

Build FROM cyclus_22.04_conda/cyclus:stable

• Cycamore: Failure ❌
• Cymetric: Skipped due to upstream failure ⚠️

[abachma2]

Hi @bennibbelink. It looks like this change is mostly so that the website page looks cleaner, correct? I suggested removing the indent so that it renders well on Github.

If this is mostly just for website rendering, we may want to take a look at some of the numbering on that page; the numbering restarts in weird places. Some of it may be from this page, but some may be the .rst file for the website

[bennibbelink]

I am having trouble fixing the numbering. It seems to be finicky since we're injecting sections of DEPENDENCIES.rst into the middle of a numbered list in user/install_binary.rst.

[abachma2]

I was thinking that part might be tricky. If it's not possible for now, I won't let that block this PR from being merged.

[gonuke]

What's the best way to preview how these things end up in the website? I'm guessing it's a lot of temporary local customization???...

[abachma2]

Personally, I copy the contents of this file into the source/user/CYCAMORE_DEPS.rst file in the website repo, then remove the line in the Makefile that pulls it from this repo. That way it won't overwrite that file when you build via make gh-preview.

That, or you can change the Makefile to point to this fork and repo for this file, but I've found that doesn't always capture the latest updates to the file for some reason.

[bennibbelink]

That, or you can change the Makefile to point to this fork and repo for this file, but I've found that doesn't always capture the latest updates to the file for some reason.

Near the top of the Makefile in cyclus/cyclus.github.com there are variables set for CYCAMORE_GIT_FORK and CYCAMORE_GIT_BRANCH. If you set them to bennibbelink and fix-link, respectively, the DEPENDENCIES.rst and INSTALL.rst from this branch will get fetched and built into the local site. This is my typical workflow, I have noticed that there is a slight delay from when you push to GitHub and when those changes will be fetched, similar to @abachma2, but usually its on the order of a minute or two.

[abachma2]

Hi @bennibbelink. Thanks for making those changes. The numbering is still a little weird, and I made a comment about that.

[abachma2]

When this renders on GitHub, this line and l.60 both show up with a 1 for the numbering. This may be because of the .. website_include_conda_end in the middle. If you build the website, does the numbering all look good? If so, then I think that's a bigger priority and should keep it as is.

[bennibbelink]

Thanks for the reminder. I've modified it now to include all the information needed for the website, and should be considered in conjunction with cyclus.github.com PR #364. The numbering is looking good on my local build now.

[abachma2]

Approving this now, but I'll merge after I look at 364 in the website

[gonuke]

To test this in conjunction with cyclus/cyclus.github.com#364, do I need to do an ad-hoc change to the Makefile in cyclus/cyclus.github.com#364 so that it loads this updated version?

[bennibbelink]

To test this in conjunction with cyclus/cyclus.github.com#364, do I need to do an ad-hoc change to the Makefile in cyclus/cyclus.github.com#364 so that it loads this updated version?

Correct, you need to reference my fork and the fix-link branch.

[gonuke]

Let's dive in and see how this comes together on the website