-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix debian package generation process and add to CI #593
Conversation
Build Status Report - 73c2dc8 - 2024-04-05 01:40:29 +0000Build
|
Tested on my fork - https://github.com/bennibbelink/cycamore/releases/tag/1.6.4 I'm able to install cycamore on a fresh |
Unfortunately CI won't pass on this PR until a |
Do you think we should wait to merge, or go ahead now, and repair if there are issues later |
Best practice would probably suggest we wait. However, potential issues would likely be noticed in the Cyclus release first since they follow the same general procedure - so we would have the opportunity to apply fixes before we issue a cycamore release. I think I lean towards merging and getting the two repos in the same state now (in terms of Deb generation) instead of having them out of sync and trying to catch up cycamore and patch issues all in one go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bennibbelink - let's see how this works on our release.
Closes #592. Adds steps to
publish_release.yml
to build a Debian package and upload it to the release.