Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Version Management #589

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Update Version Management #589

merged 4 commits into from
Mar 21, 2024

Conversation

bennibbelink
Copy link
Contributor

Implements similar changes as in cyclus #1696. The cycamore version will be hardcoded in CMakeLists.txt and CMake will propagate it throughout the appropriate files.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2024 •
edited
Loading

Build Status Report

Build FROM cyclus_20.04_apt/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_20.04_apt/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_20.04_conda/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_20.04_conda/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_apt/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_22.04_apt/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_conda/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_22.04_conda/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️

@bennibbelink bennibbelink requested a review from gonuke March 21, 2024 20:15
gonuke
gonuke approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @bennibbelink

@gonuke gonuke merged commit 945211c into main Mar 21, 2024
19 checks passed
@bennibbelink bennibbelink deleted the version-management branch March 21, 2024 23:08
@bennibbelink bennibbelink mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gonuke gonuke gonuke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bennibbelink @gonuke