Rebuild when test file changes #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix ci refactor
upload PR number
modify comment
fix cyclus_tag
try using build context to define image
try build context as repository owners registry
try image output
Revert "try image output"
Build Status ReportBuild
|
gonuke
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #476. CMake wasn't rebuilding on a change to the test files because the
cyclus_unit_teststarget doesn't reference the source files directly - we use theUseCyclusmacro to handle a lot of the cycamore build and "return" env vars holding build info.This forces cmake to rebuild the
test/directory when one of the test files changes.I'm no CMake expert... if someone knows a better way to handle this please let me know.