forked from hashicorp/terraform
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cy v1.3.7 #1
Open
tparvu
wants to merge
778
commits into
cycloidio:main
Choose a base branch
from
tparvu:cy-v1.3.7
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Cy v1.3.7 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were attempting to infer the checkable object address kind of a given address by whether it included "output" in the position where a resource type name would otherwise go. That was already potentially risky because we've historically not prevented a resource type named "output", and it's also a forward-compatibility hazard in case we introduce additional object kinds with entirely-new addressing schemes in future. Given that, we'll instead always be explicit about what kind of address we're storing in a wire or file format, so that we can make sure to always use the intended parser when reading an address back into memory, or return an error if we encounter a kind we're not familiar with.
This is a clumsy way to do this, but a pragmatic way to inform potential consumers that this part of the format is not yet finalized without having to read the docs to see our warning about that. We need to get some practical experience with a few different consumers making use of this format before we can be confident that it's designed appropriately. We're not _expecting_ to break it, but we'd like to leave the opportunity open in case we quickly learn that there's something non-ideal about this design.
rephrased according to the suggestion.
Update init.mdx
…hemas along to PersistState in the remote state
Add a new ChangeReason, ReasonDeleteBecauseNoMoveTarget, to provide better information in cases where a planned deletion is due to moving a resource to a target not in configuration. Consider a case in which a resource instance exists in state at address A, and the user adds a moved block to move A to address B. Whether by the user's intention or not, address B does not exist in configuration. Terraform combines the move from A to B, and the lack of configuration for B, into a single delete action for the (previously nonexistent) entity B. Prior to this commit, the Terraform plan will report that resource B will be destroyed because it does not exist in configuration, without explicitly connecting this to the move. This commit provides the user an additional clue as to what has happened, in a case in which Terraform has elided a user's action and inaction into one potentially destructive change.
Send the JSON state representation to Cloud backend (when available)
* remove deprecated backends * remove backend docs Remove references to deprecated backends from docs.
Co-authored-by: Katy Moe <[email protected]>
…an-orphan-deleted/hideously-crisp-vulture Backport of A deleted orphan should have no planned change into v1.3
…3-destroy-perf/uniformly-included-yak Backport of check walkDestroy to help DestroyEdgeTransformer into v1.3
… builds into v1.3 (hashicorp#32285) * no-op commit due to failed cherry-picking * add missing files Co-authored-by: temp <[email protected]> Co-authored-by: Liam Cervante <[email protected]>
…rkspace-delete-rum-docs/marginally-rested-bream Backport of Update workspace delete command docs to reference RUM vs empty state into v1.3
Remove future-facing language from docs (WIP)
…tput-perf/honestly-engaged-tetra Backport of don't re-set changes for refreshed outputs into v1.3
Co-authored-by: hellertang <[email protected]>
Co-authored-by: kmoe <[email protected]>
Co-authored-by: Bryan Stenson <[email protected]>
Co-authored-by: Conor Evans <[email protected]>
…e constraints into v1.3 (hashicorp#32393) * backport of commit 5b27ff2 * backport of commit 1f12d16 * backport of commit e82ef31 * backport of commit 57ef86b * backport of commit a1d4541 Co-authored-by: Liam Cervante <[email protected]>
…g-apt-repos/unlikely-endless-quail Backport of website: add missing Ubuntu apt repositories jammy and kinetic to the list into v1.3
…nore-changes-panic/totally-sure-feline Backport of don't panic with a null list block value in config into v1.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.