Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#273 fix login logic and api_key handling. #274

Merged
merged 99 commits into from
Jul 4, 2024
Merged

#273 fix login logic and api_key handling. #274

merged 99 commits into from
Jul 4, 2024

Conversation

fhacloid
Copy link
Contributor

@fhacloid fhacloid commented Jun 11, 2024 •
edited
Loading

This PR fix a part of this issue:

  • If the config is empty, the CLI no longer panics
  • CLI write its config as 0600 permissions
  • Allow to set the cycloid API key via env var
  • Make the CLI use CY_API_KEY instead of TOKEN as API_KEY env var (the old one still works, but emits a warning)
  • Fix the --org flag behavior, it's now a global flag and org can also be set using CY_ORG env var for convenience

Sorry if the PR is massive, I had to rebase and it got dirty

@fhacloid fhacloid linked an issue Jun 11, 2024 that may be closed by this pull request
Fix bad API_KEY handling. #273
Open
4 tasks
@fhacloid fhacloid requested review from talset and gaelL June 11, 2024 09:33
@fhacloid fhacloid marked this pull request as ready for review June 12, 2024 11:16
@fhacloid fhacloid marked this pull request as draft June 12, 2024 11:16
fhacloid added 22 commits July 2, 2024 15:34
@fhacloid
fix(deprecation): move ioutil to os ReadFile command
7b866f4
@fhacloid
func: move old command to create-raw-env
763a7b0
@fhacloid
func(internal): add Debug function and make Warning function public
38e2fd9
@fhacloid
wip: add first draft of create-env command.
b3d01d4
@fhacloid
wip: update of the middleware to support forms input
b14af5f
@fhacloid
misc: add draft of test for create-env, will integrate real tests later
8417ab8
@fhacloid
fix: fixed UpdateProject Middleware
de83bff
@fhacloid
misc: add real 'test'
82dfec0
@fhacloid
func: add create-stackforms-env, move create-env to create-raw-env
9ca080a
@fhacloid
fix: fix client generation to includ bad section Organization Project
21f4333
@fhacloid
func: add generated client method for getProjectConfig
047571f
@fhacloid
func: indent JSON printer and add newline at EOF to make it more
71a8033 
readable
@fhacloid
misc: change deprecated method
9048b73
@fhacloid
func: add env creation command using stackforms
ac53b07
@fhacloid
misc: add createFormsConfig middleware implementation
11f09b6
@fhacloid
func: add get-env-config command
6bba46d
@fhacloid
misc: add new command to cmd
be152a6
@fhacloid
func: add utility function for forms and arg/flag parsing
5d0c910
@fhacloid
misc: remove deprecated function
e5df498
@fhacloid
misc: add client file
54e39a2
@fhacloid
func: add get-env-config from stackforms
185b772
@fhacloid
misc: add nixos dev env shinanigan
ff4d4fa
fhacloid added 20 commits July 2, 2024 15:40
@fhacloid
func: make command to fill org via env var
ec6232d
@fhacloid
func: allow setting API_KEY via env var for login
711cfc7
@fhacloid
fix: remove last required org flags
3ab0773
@fhacloid
func: make login use CY_API_KEY env var as preference
1aab90a
@fhacloid
fix: add proper error and nil handling in config read/write
e8b6117
@fhacloid
fix: change config file permissions to 0600
257ca9b
@fhacloid
fix: error handling on config open
693d717
@fhacloid
misc: add nixos dev env shinanigan
562714a
@fhacloid
func: update go version to 1.21
12d0932
@fhacloid
func: bump go version to 1.22.4
cd63328
@fhacloid
misc: fix deprecated code
10d8a61
@fhacloid
func: update generated client with 0.31.0 go-swagger
8ec5a9f
@fhacloid
Bump swagger client to version v5.0.49-saas
5830be0
@fhacloid
func: change api token env var to CY_API_TOKEN
87e9a14
@fhacloid
func: make command to fill org via env var
11412a2
@fhacloid
func: allow setting API_KEY via env var for login
d751041
@fhacloid
fix: remove last required org flags
75e4b3c
@fhacloid
func: make login use CY_API_KEY env var as preference
0e3b8f8
@fhacloid
Merge branch '273-fix-login' of github.com:cycloidio/cycloid-cli into…
7923097 
… 273-fix-login
@fhacloid
fix: fix bad merge
c177fab
@fhacloid fhacloid self-assigned this Jul 2, 2024
@fhacloid fhacloid marked this pull request as ready for review July 2, 2024 14:44
@fhacloid fhacloid merged commit ad0559f into develop Jul 4, 2024
1 check passed
@fhacloid fhacloid deleted the 273-fix-login branch July 4, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaelL gaelL gaelL approved these changes

@talset talset Awaiting requested review from talset

Assignees

@fhacloid fhacloid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix bad API_KEY handling.
3 participants
@fhacloid @gaelL @cycloid-machine