Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad API_KEY handling. #273

Open
4 of 7 tasks
fhacloid opened this issue Jun 11, 2024 · 1 comment · Fixed by #274
Open
4 of 7 tasks

Fix bad API_KEY handling. #273

fhacloid opened this issue Jun 11, 2024 · 1 comment · Fixed by #274
Assignees
Labels
enhancement New feature or request

Comments

@fhacloid
Copy link
Contributor

fhacloid commented Jun 11, 2024

There are a number of issue detected with the current handling of the API KEY:

  • CLI seems to try to send the auth token of a parent org when making actions on a child org.
  • CLI writes config with 0644 permissions on user's home which is bad (fix perm)
  • If the config is empty, the CLI panics (bad errors handling and nil map assignment)
  • We should allow (and recommend) to fill in the token via env var. Passing the token via arg will write it in the user's bash history.

Tasks

Preview Give feedback
@fhacloid fhacloid self-assigned this Jun 11, 2024
@fhacloid
Copy link
Contributor Author

@gaelL @talset @marcoldp Any suggestions on this one ?

@fhacloid fhacloid linked a pull request Jun 11, 2024 that will close this issue
fhacloid added a commit that referenced this issue Jul 4, 2024
#273 fix login logic and api_key handling.
@fhacloid fhacloid reopened this Jul 4, 2024
@fhacloid fhacloid added the enhancement New feature or request label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant